Print the number of failed tests

tools/testing/dart/test_progress.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test_progress;
 
 import "dart:io";
 import "dart:io" as io;
 import "http_server.dart" as http_server;
 import "status_file_parser.dart";
@@ skipping 110 matching lines @@
   }
   for (Command c in test.commands) {
     output.add('');
     String message = (c == test.commands.last
         ? "Command line" : "Compilation command");
     output.add('$message: $c');
   }
   return output;
 }
 
+String _buildSummaryEnd(int failedTests) {
+    if (failedTests == 0) {
+      return '\n===\n=== All tests succeeded\n===\n';
+    } else {
+      var pluralSuffix = failedTests != 1 ? 's' : '';
+      return '\n===\n=== ${failedTests} test$pluralSuffix failed\n===\n';
+    }
+}
+
 
 class EventListener {
   void testAdded() { }
   void start(TestCase test) { }
   void done(TestCase test) { }
   void allTestsKnown() { }
   void allDone() { }
 }
 
 class ExitCodeSetter extends EventListener {
@@ skipping 176 matching lines @@
       status = 'fail';
     }
     print('Done ${test.configurationString} ${test.displayName}: $status');
   }
 }
 
 class TestFailurePrinter extends EventListener {
   bool _printSummary;
   var _formatter;
   var _failureSummary = <String>[];
+  var _failedTests= 0;
 
   TestFailurePrinter(this._printSummary,
                      [this._formatter = const Formatter()]);
 
   void done(TestCase test) {
     if (test.lastCommandOutput.unexpectedOutput) {
+      _failedTests++;
       var lines = _buildFailureOutput(test, _formatter);
       for (var line in lines) {
         print(line);
       }
       print('');
       if (_printSummary) {
         _failureSummary.addAll(lines);
         _failureSummary.add('');
       }
     }
   }
 
   void allDone() {
     if (_printSummary) {
       if (!_failureSummary.isEmpty) {
         print('\n=== Failure summary:\n');
         for (String line in _failureSummary) {
           print(line);
         }
         print('');
+
+        print(_buildSummaryEnd(_failedTests));

[kustermann, 2013/05/02 14:13:00]

If we want to print it always (not just if something failed) we have to move it
one line down.

       }
     }
   }
 }
 
 class ProgressIndicator extends EventListener {
   ProgressIndicator(this._startTime);
 
   factory ProgressIndicator.fromName(String name,
                                      DateTime startTime,
@@ skipping 27 matching lines @@
     } else {
       _passedTests++;
     }
     _printDoneProgress(test);
   }
 
   void allTestsKnown() {
     _allTestsKnown = true;
   }
 
-  void allDone() {
-    _printStatus();
-  }
-
   void _printStartProgress(TestCase test) {}
   void _printDoneProgress(TestCase test) {}
 
-  void _printStatus() {
-    if (_failedTests == 0) {
-      print('\n===');
-      print('=== All tests succeeded');
-      print('===\n');
-    } else {
-      var pluralSuffix = _failedTests != 1 ? 's' : '';
-      print('\n===');
-      print('=== ${_failedTests} test$pluralSuffix failed');
-      print('===\n');
-    }
-  }
-
-  int get numFailedTests => _failedTests;
-
   int _completedTests() => _passedTests + _failedTests;
 
   int _foundTests = 0;
   int _passedTests = 0;
   int _failedTests = 0;
   bool _allTestsKnown = false;
   DateTime _startTime;
 }
 
 abstract class CompactIndicator extends ProgressIndicator {
@@ skipping 82 matching lines @@
     if (!_failureSummary.isEmpty) {
       print('@@@STEP_FAILURE@@@');
       if (stepName != null) {
         print('@@@BUILD_STEP $stepName failures@@@');
       }
       for (String line in _failureSummary) {
         print(line);
       }
       print('');
     }
-    super.allDone();
+    print(_buildSummaryEnd(_failedTests));
   }
 }