Add JSON protocol support for groups.

Add JSON protocol support for groups.

R=kevmoo@google.com

Committed: https://github.com/dart-lang/test/commit/f6c814f63d6fe900c3628bc22a9d6b6746c4a03c

[kevmoo, 2015-11-24 05:04:32]

One failing test, one nit about imports, otherwise LGTM

> pub run test test/runner/json_reporter_test.dart
00:09 +11 -1: skip: reports skipped groups
  The schedule had 1 errors:
  ScheduleError:
  | Expected: <8>
  |   Actual: <7>
  | Expected
[{"protocolVersion":"0.1.0","runnerVersion":null,"type":"start","time":0},
{"test":{"id":0,"name":"loading
test.dart","groupIDs":[],"metadata":{"skip":false,"skipReason":null}},"type":"testStart","time":0},
{"testID":0,"result":"success","hidden":true,"type":"testDone","time":160},
{"group":{"id":1,"parentID":null,"name":null,"metadata":{"skip":false,"skipReason":null}},"type":"group","time":162},
{"test":{"id":2,"name":"skip","groupIDs":[1],"metadata":{"skip":true,"skipReason":null}},"type":"testStart","time":163},
{"testID":2,"result":"success","hidden":false,"type":"testDone","time":163},
{"success":true,"type":"done","time":165}] to match [{type: start,
protocolVersion: 0.1.0, runnerVersion: null}, {type: testStart, test: {id: 0,
name: loading test.dart, groupIDs: [], metadata: {skip: false, skipReason:
null}}}, {type: testDone, testID: 0, result: success, hidden: true}, {type:
group, group: {id: 1, name: null, parentID: null, metadata: {skip: false,
skipReason: null}}}, {type: group, group: {id: 2, name: skip, parentID: 1,
metadata: {skip: true, skipReason: null}}}, {type: testStart, test: {id: 3,
name: skip, groupIDs: [1, 2], metadata: {skip: true, skipReason: null}}}, {type:
testDone, testID: 3, result: success, hidden: false}, {type: done, success:
true}].

https://codereview.chromium.org/1469863005/diff/1/lib/src/runner/reporter/jso...
File lib/src/runner/reporter/json.dart (right):

https://codereview.chromium.org/1469863005/diff/1/lib/src/runner/reporter/jso...
lib/src/runner/reporter/json.dart:14: import '../load_suite.dart';
missing imports for Group and Metadata

[nweiz, 2015-11-24 05:06:34]

Code review changes

[nweiz, 2015-11-24 05:07:11]

The failing test is due to a pre-existing bug that this CL uncovered. I just
sent a separate CL to fix that bug.

https://codereview.chromium.org/1469863005/diff/1/lib/src/runner/reporter/jso...
File lib/src/runner/reporter/json.dart (right):

https://codereview.chromium.org/1469863005/diff/1/lib/src/runner/reporter/jso...
lib/src/runner/reporter/json.dart:14: import '../load_suite.dart';
On 2015/11/24 05:04:31, kevmoo wrote:
> missing imports for Group and Metadata

Done.

[kevmoo, 2015-11-24 05:09:20]

On 2015/11/24 05:07:11, nweiz wrote:
> The failing test is due to a pre-existing bug that this CL uncovered. I just
> sent a separate CL to fix that bug.
> 
>
https://codereview.chromium.org/1469863005/diff/1/lib/src/runner/reporter/jso...
> File lib/src/runner/reporter/json.dart (right):
> 
>
https://codereview.chromium.org/1469863005/diff/1/lib/src/runner/reporter/jso...
> lib/src/runner/reporter/json.dart:14: import '../load_suite.dart';
> On 2015/11/24 05:04:31, kevmoo wrote:
> > missing imports for Group and Metadata
> 
> Done.

I have that patch applied – then w/ this patch – and I get the error

[nweiz, 2015-11-24 05:13:15]

Committed patchset #2 (id:20001) manually as
f6c814f63d6fe900c3628bc22a9d6b6746c4a03c (presubmit successful).