Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: lib/src/runner/browser/iframe_test.dart

Issue 1469863005: Add JSON protocol support for groups. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/iframe_listener.dart ('k') | lib/src/runner/engine.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/browser/iframe_test.dart
diff --git a/lib/src/runner/browser/iframe_test.dart b/lib/src/runner/browser/iframe_test.dart
index 875672ed6863dacef93ca8082a3568f4f373c5d0..8711dddc6e49b5009fa52a3ab91a14ece933ff67 100644
--- a/lib/src/runner/browser/iframe_test.dart
+++ b/lib/src/runner/browser/iframe_test.dart
@@ -4,6 +4,7 @@
library test.runner.browser.iframe_test;
+import '../../backend/group.dart';
import '../../backend/live_test.dart';
import '../../backend/live_test_controller.dart';
import '../../backend/metadata.dart';
@@ -31,7 +32,7 @@ class IframeTest extends Test {
IframeTest(this.name, this.metadata, this._channel, {StackTraceMapper mapper})
: _mapper = mapper;
- LiveTest load(Suite suite) {
+ LiveTest load(Suite suite, {Iterable<Group> groups}) {
var controller;
var testChannel;
controller = new LiveTestController(suite, this, () {
@@ -69,7 +70,7 @@ class IframeTest extends Test {
// browser test needs to clean up on the file system anyway.
testChannel.sink.close();
if (!controller.completer.isCompleted) controller.completer.complete();
- });
+ }, groups: groups);
return controller.liveTest;
}
« no previous file with comments | « lib/src/runner/browser/iframe_listener.dart ('k') | lib/src/runner/engine.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698