Issue 14668014: Report CompileTimeErrorCode.RECURSIVE_FACTORY_REDIRECT

Issue 14668014: Report CompileTimeErrorCode.RECURSIVE_FACTORY_REDIRECT (Closed)

Created:
7 years, 7 months ago by scheglov

Modified:
7 years, 7 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report CompileTimeErrorCode.RECURSIVE_FACTORY_REDIRECT R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22759

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+181 lines, -11 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/element/ConstructorElement.java	View	1 chunk	+7 lines, -0 lines	1 comment	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/ConstructorElementImpl.java	View	3 chunks	+19 lines, -0 lines	1 comment	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/handle/ConstructorElementHandle.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java	View	2 chunks	+19 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	4 chunks	+44 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	2 chunks	+70 lines, -9 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/14668014/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/element/ConstructorElement.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/element/ConstructorElement.java (right): https://codereview.chromium.org/14668014/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/element/ConstructorElement.java#newcode32 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/element/ConstructorElement.java:32: * Return the constructor to which this constructor ...

7 years, 7 months ago (2013-05-15 21:36:33 UTC) #2

scheglov

7 years, 7 months ago (2013-05-15 22:19:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22759 (presubmit successful).

Expand Messages | Collapse Messages