Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

Issue 14668014: Report CompileTimeErrorCode.RECURSIVE_FACTORY_REDIRECT (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
index 6675545e0e82524d93049d55b854fb722eab0f35..b50fa988439035b4803e86a8bfe9de1f798b50b6 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
@@ -79,6 +79,7 @@ import com.google.dart.engine.error.ErrorCode;
import com.google.dart.engine.error.StaticTypeWarningCode;
import com.google.dart.engine.error.StaticWarningCode;
import com.google.dart.engine.internal.element.ClassElementImpl;
+import com.google.dart.engine.internal.element.ConstructorElementImpl;
import com.google.dart.engine.internal.element.FieldFormalParameterElementImpl;
import com.google.dart.engine.internal.element.LabelElementImpl;
import com.google.dart.engine.internal.element.MultiplyDefinedElementImpl;
@@ -461,6 +462,24 @@ public class ElementResolver extends SimpleASTVisitor<Void> {
}
@Override
+ public Void visitConstructorDeclaration(ConstructorDeclaration node) {
+ super.visitConstructorDeclaration(node);
+ // set redirected constructor
+ {
+ ConstructorName redirectedNode = node.getRedirectedConstructor();
+ if (redirectedNode != null) {
+ ConstructorElement redirectedElement = redirectedNode.getElement();
+ ConstructorElement element = node.getElement();
+ if (element instanceof ConstructorElementImpl) {
+ ((ConstructorElementImpl) element).setRedirectedConstructor(redirectedElement);
+ }
+ }
+ }
+ // done
+ return null;
+ }
+
+ @Override
public Void visitConstructorFieldInitializer(ConstructorFieldInitializer node) {
SimpleIdentifier fieldName = node.getFieldName();
ClassElement enclosingClass = resolver.getEnclosingClass();

Powered by Google App Engine
This is Rietveld 408576698