Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 14662003: Don't show a stack trace on a bad path dependency path. (Closed)

Created:
7 years, 7 months ago by Bob Nystrom
Modified:
7 years, 7 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't show a stack trace on a bad path dependency path. This is a user-facing error, so there shouldn't be a stack dump. BUG=https://code.google.com/p/dart/issues/detail?id=10123 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=22448

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M sdk/lib/_internal/pub/lib/src/path_source.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/nonexistent_dir_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/path_is_file_test.dart View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
7 years, 7 months ago (2013-05-02 20:33:10 UTC) #1
nweiz
lgtm
7 years, 7 months ago (2013-05-06 23:05:06 UTC) #2
Bob Nystrom
7 years, 7 months ago (2013-05-07 00:11:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22448 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698