Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: sdk/lib/_internal/pub/test/install/path/nonexistent_dir_test.dart

Issue 14662003: Don't show a stack trace on a bad path dependency path. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS d.file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS d.file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE d.file. 3 // BSD-style license that can be found in the LICENSE d.file.
4 4
5 import 'dart:io'; 5 import 'dart:io';
6 6
7 import 'package:pathos/path.dart' as path; 7 import 'package:pathos/path.dart' as path;
8 import 'package:scheduled_test/scheduled_test.dart'; 8 import 'package:scheduled_test/scheduled_test.dart';
9 9
10 import '../../../lib/src/exit_codes.dart' as exit_codes;
11 import '../../descriptor.dart' as d; 10 import '../../descriptor.dart' as d;
12 import '../../test_pub.dart'; 11 import '../../test_pub.dart';
13 12
14 main() { 13 main() {
15 initConfig(); 14 initConfig();
16 integration('path dependency to non-existent directory', () { 15 integration('path dependency to non-existent directory', () {
17 var badPath = path.join(sandboxDir, "bad_path"); 16 var badPath = path.join(sandboxDir, "bad_path");
18 17
19 d.dir(appPath, [ 18 d.dir(appPath, [
20 d.pubspec({ 19 d.pubspec({
21 "name": "myapp", 20 "name": "myapp",
22 "dependencies": { 21 "dependencies": {
23 "foo": {"path": badPath} 22 "foo": {"path": badPath}
24 } 23 }
25 }) 24 })
26 ]).create(); 25 ]).create();
27 26
28 // TODO(rnystrom): The "\" in a Windows path gets treated like a regex 27 // TODO(rnystrom): The "\" in a Windows path gets treated like a regex
29 // character, so hack escape. A better fix is to use a literal string 28 // character, so hack escape. A better fix is to use a literal string
30 // instead of a RegExp to validate, but that requires us to move the 29 // instead of a RegExp to validate, but that requires us to move the
31 // stack traces out of the stderr when we invoke pub. See also: #4706. 30 // stack traces out of the stderr when we invoke pub. See also: #4706.
32 var escapePath = badPath.replaceAll(r"\", r"\\"); 31 var escapePath = badPath.replaceAll(r"\", r"\\");
33 32
34 schedulePub(args: ['install'], 33 schedulePub(args: ['install'],
35 error: 34 error:
36 new RegExp("Could not find package 'foo' at '$escapePath'."), 35 new RegExp("Could not find package 'foo' at '$escapePath'."),
37 exitCode: exit_codes.DATA); 36 exitCode: 1);
38 }); 37 });
39 } 38 }
OLDNEW
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/path_source.dart ('k') | sdk/lib/_internal/pub/test/install/path/path_is_file_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698