- Remove kFreeBit, as it is not needed any longer

- Remove kFreeBit, as it is not needed any longer
  except during snapshotting.
- Move the kWatchBit into the available space as its
  use does not overlap with snapshotting.

R=vegorov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22181

[Vyacheslav Egorov (Google), 2013-04-30 14:36:01]

lgtm

https://codereview.chromium.org/14648004/diff/1/runtime/vm/scavenger.cc
File runtime/vm/scavenger.cc (right):

https://codereview.chromium.org/14648004/diff/1/runtime/vm/scavenger.cc#newco...
runtime/vm/scavenger.cc:23: // objects because scavenger can never encounter
free list element during
this comment is out of date (mentions free lists and kFreeBit)

also note that forwarding bit must not intersect with bits of the forwarded
address which holds because objects are properly aligned.

https://codereview.chromium.org/14648004/diff/1/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/14648004/diff/1/runtime/vm/snapshot.cc#newcod...
runtime/vm/snapshot.cc:125: // No object can have kFreeBit and kMarkBit set
simultaneously. If kFreeBit
comment mentions kFreeBit

[Ivan Posva, 2013-04-30 15:03:53]

https://codereview.chromium.org/14648004/diff/1/runtime/vm/scavenger.cc
File runtime/vm/scavenger.cc (right):

https://codereview.chromium.org/14648004/diff/1/runtime/vm/scavenger.cc#newco...
runtime/vm/scavenger.cc:23: // objects because scavenger can never encounter
free list element during
On 2013/04/30 14:36:01, Vyacheslav Egorov (Google) wrote:
> this comment is out of date (mentions free lists and kFreeBit)
> 
> also note that forwarding bit must not intersect with bits of the forwarded
> address which holds because objects are properly aligned.

Simplified comment.

https://codereview.chromium.org/14648004/diff/1/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/14648004/diff/1/runtime/vm/snapshot.cc#newcod...
runtime/vm/snapshot.cc:125: // No object can have kFreeBit and kMarkBit set
simultaneously. If kFreeBit
On 2013/04/30 14:36:01, Vyacheslav Egorov (Google) wrote:
> comment mentions kFreeBit

Done.

[Ivan Posva, 2013-04-30 15:06:00]

Committed patchset #1 manually as r22181 (presubmit successful).

[siva, 2013-04-30 17:12:56]

lgtm