- Remove kFreeBit, as it is not needed any longer

runtime/vm/scavenger.cc

Index: runtime/vm/scavenger.cc
===================================================================
--- runtime/vm/scavenger.cc	(revision 22179)
+++ runtime/vm/scavenger.cc	(working copy)
@@ -19,14 +19,14 @@
 
 namespace dart {
 
-// Scavenger uses RawObject::kFreeBit to distinguish forwaded and non-forwarded
+// Scavenger uses RawObject::kMarkBit to distinguish forwaded and non-forwarded
 // objects because scavenger can never encounter free list element during

[Vyacheslav Egorov (Google), 2013/04/30 14:36:01]

this comment is out of date (mentions free lists and kFreeBit)

also note that forwarding bit must not intersect with bits of the forwarded
address which holds because objects are properly aligned.

[Ivan Posva, 2013/04/30 15:03:53]

Simplified comment.

 // evacuation and thus all objects scavenger encounters have
 // kFreeBit cleared.
 enum {
-  kForwardingMask = 1,
+  kForwardingMask = 1 << RawObject::kMarkBit,
   kNotForwarded = 0,
-  kForwarded = 1,
+  kForwarded = kForwardingMask,
 };
 
 
@@ -299,7 +299,6 @@
   // Verify assumptions about the first word in objects which the scavenger is
   // going to use for forwarding pointers.
   ASSERT(Object::tags_offset() == 0);
-  ASSERT(kForwardingMask == (1 << RawObject::kFreeBit));
 
   // Allocate the virtual memory for this scavenge heap.
   space_ = VirtualMemory::Reserve(max_capacity);