Issue 14646035: Syncing CssStyleDeclaration.setPropertyValue's signature between dart2js and dartium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14646035: Syncing CssStyleDeclaration.setPropertyValue's signature between dart2js and dartium (Closed)

Created:
7 years, 7 months ago by blois

Modified:
7 years, 7 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Syncing CssStyleDeclaration.setPropertyValue's signature between dart2js and dartium Because of IDL changes, the generated signature changed but the dart2js code had a polyfill which did not change. The last parameter really should be optional, but this is dependent on https://code.google.com/p/dart/issues/detail?id=9156. BUG=10583 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=22606

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -1 line)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

Emily Fortuna

"lgtm". sigh. :-( I'll get to fixing the bigger issue soon!!!

7 years, 7 months ago (2013-05-10 20:25:51 UTC) #2

kevmoo-old

Any chance we could have a default value of '' for priority? Or better yet, ...

7 years, 7 months ago (2013-05-10 20:29:27 UTC) #3

blois

PTAL, updated to make priority default to null. I'm defaulting it to a null string ...

7 years, 7 months ago (2013-05-10 21:02:21 UTC) #4

blois

7 years, 7 months ago (2013-05-10 23:22:21 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r22606 (presubmit successful).