Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 14646035: Syncing CssStyleDeclaration.setPropertyValue's signature between dart2js and dartium (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /// The Dart HTML library. 1 /// The Dart HTML library.
2 library dart.dom.html; 2 library dart.dom.html;
3 3
4 import 'dart:async'; 4 import 'dart:async';
5 import 'dart:collection'; 5 import 'dart:collection';
6 import 'dart:_collection-dev' hide Symbol; 6 import 'dart:_collection-dev' hide Symbol;
7 import 'dart:html_common'; 7 import 'dart:html_common';
8 import 'dart:indexed_db'; 8 import 'dart:indexed_db';
9 import 'dart:isolate'; 9 import 'dart:isolate';
10 import 'dart:json' as json; 10 import 'dart:json' as json;
(...skipping 2154 matching lines...) Expand 10 before | Expand all | Expand 10 after
2165 @DomName('CSSStyleDeclaration.removeProperty') 2165 @DomName('CSSStyleDeclaration.removeProperty')
2166 @DocsEditable 2166 @DocsEditable
2167 String removeProperty(String propertyName) native; 2167 String removeProperty(String propertyName) native;
2168 2168
2169 2169
2170 String getPropertyValue(String propertyName) { 2170 String getPropertyValue(String propertyName) {
2171 var propValue = _getPropertyValue(propertyName); 2171 var propValue = _getPropertyValue(propertyName);
2172 return propValue != null ? propValue : ''; 2172 return propValue != null ? propValue : '';
2173 } 2173 }
2174 2174
2175 @DomName('CSSStyleDeclaration.setProperty')
2175 void setProperty(String propertyName, String value, [String priority]) { 2176 void setProperty(String propertyName, String value, [String priority]) {
2176 // try/catch for IE9 which throws on unsupported values. 2177 // try/catch for IE9 which throws on unsupported values.
2177 try { 2178 try {
2179 if (priority == null) {
2180 priority = '';
2181 }
2178 JS('void', '#.setProperty(#, #, #)', this, propertyName, value, priority); 2182 JS('void', '#.setProperty(#, #, #)', this, propertyName, value, priority);
2179 // Bug #2772, IE9 requires a poke to actually apply the value. 2183 // Bug #2772, IE9 requires a poke to actually apply the value.
2180 if (JS('bool', '!!#.setAttribute', this)) { 2184 if (JS('bool', '!!#.setAttribute', this)) {
2181 JS('void', '#.setAttribute(#, #)', this, propertyName, value); 2185 JS('void', '#.setAttribute(#, #)', this, propertyName, value);
2182 } 2186 }
2183 } catch (e) {} 2187 } catch (e) {}
2184 } 2188 }
2185 2189
2186 /** 2190 /**
2187 * Checks to see if CSS Transitions are supported. 2191 * Checks to see if CSS Transitions are supported.
(...skipping 25746 matching lines...) Expand 10 before | Expand all | Expand 10 after
27934 _position = nextPosition; 27938 _position = nextPosition;
27935 return true; 27939 return true;
27936 } 27940 }
27937 _current = null; 27941 _current = null;
27938 _position = _array.length; 27942 _position = _array.length;
27939 return false; 27943 return false;
27940 } 27944 }
27941 27945
27942 T get current => _current; 27946 T get current => _current;
27943 } 27947 }
OLDNEW
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698