Issue 14622019: Report CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT

Issue 14622019: Report CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT (Closed)

Created:
7 years, 7 months ago by scheglov

Modified:
7 years, 7 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22694

Patch Set 2 : Check for all 'super' expressions. Don't resolve methods/accessors if invalid. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+166 lines, -79 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java	View	1	6 chunks	+42 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/ElementResolverTest.java	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	1	2 chunks	+94 lines, -66 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View	1	3 chunks	+0 lines, -8 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

Needs additional checks or slight re-work. https://codereview.chromium.org/14622019/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java (right): https://codereview.chromium.org/14622019/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java#newcode668 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java:668: if (checkForSuperInInvalidContext(target)) { ...

7 years, 7 months ago (2013-05-14 14:56:07 UTC) #3

scheglov

PTAL https://codereview.chromium.org/14622019/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java (right): https://codereview.chromium.org/14622019/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java#newcode668 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java:668: if (checkForSuperInInvalidContext(target)) { On 2013/05/14 14:56:07, Brian Wilkerson ...

7 years, 7 months ago (2013-05-14 16:57:32 UTC) #4

scheglov

7 years, 7 months ago (2013-05-14 18:14:00 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r22694 (presubmit successful).

Expand Messages | Collapse Messages