Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1106)

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java

Issue 14622019: Report CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Check for all 'super' expressions. Don't resolve methods/accessors if invalid. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
index 727e5e6996f6c2adb3490ba57732e4083422101c..9dd97a4ee2a83143aa905d1211be11ce571ea100 100644
--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
@@ -333,72 +333,6 @@ public class CompileTimeErrorCodeTest extends ResolverTestCase {
verify(source);
}
- public void fail_superInInvalidContext_factoryConstructor() throws Exception {
- Source source = addSource(createSource(//
- // TODO
- ));
- resolve(source);
- assertErrors(CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT);
- verify(source);
- }
-
- public void fail_superInInvalidContext_instanceVariableInitializer() throws Exception {
- Source source = addSource(createSource(//
- "class A {",
- " var a;",
- "}",
- "class B extends A {",
- " var b = super.a;",
- "}"));
- resolve(source);
- assertErrors(CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT);
- verify(source);
- }
-
- public void fail_superInInvalidContext_staticMethod() throws Exception {
- Source source = addSource(createSource(//
- "class A {",
- " static m() {}",
- "}",
- "class B extends A {",
- " static n() { return super.m(); }",
- "}"));
- resolve(source);
- assertErrors(CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT);
- verify(source);
- }
-
- public void fail_superInInvalidContext_staticVariableInitializer() throws Exception {
- Source source = addSource(createSource(//
- "class A {",
- " static a = 0;",
- "}",
- "class B extends A {",
- " static b = super.a;",
- "}"));
- resolve(source);
- assertErrors(CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT);
- verify(source);
- }
-
- public void fail_superInInvalidContext_topLevelFunction() throws Exception {
- Source source = addSource(createSource(//
- "f() {",
- " super.f();",
- "}"));
- resolve(source);
- assertErrors(CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT);
- verify(source);
- }
-
- public void fail_superInInvalidContext_variableInitializer() throws Exception {
- Source source = addSource(createSource(//
- "var v = super.v;"));
- resolve(source);
- assertErrors(CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT);
- verify(source);
- }
-
public void fail_superInitializerInObject() throws Exception {
Source source = addSource(createSource(//
// TODO(brianwilkerson) Figure out how to mock Object
@@ -2083,6 +2017,100 @@ public class CompileTimeErrorCodeTest extends ResolverTestCase {
verify(source);
}
+ public void test_superInInvalidContext_binaryExpression() throws Exception {
+ Source source = addSource(createSource(//
+ "var v = super + 0;"));
+ resolve(source);
+ assertErrors(CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT);
+ // no verify(), 'super.v' is not resolved
+ }
+
+ public void test_superInInvalidContext_constructorFieldInitializer() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " m() {}",
+ "}",
+ "class B extends A {",
+ " var f;",
+ " B() : f = super.m();",
+ "}"));
+ resolve(source);
+ assertErrors(CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT);
+ // no verify(), 'super.m' is not resolved
+ }
+
+ public void test_superInInvalidContext_factoryConstructor() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " m() {}",
+ "}",
+ "class B extends A {",
+ " factory B() {",
+ " super.m();",
+ " }",
+ "}"));
+ resolve(source);
+ assertErrors(CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT);
+ // no verify(), 'super.m' is not resolved
+ }
+
+ public void test_superInInvalidContext_instanceVariableInitializer() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " var a;",
+ "}",
+ "class B extends A {",
+ " var b = super.a;",
+ "}"));
+ resolve(source);
+ assertErrors(CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT);
+ // no verify(), 'super.a' is not resolved
+ }
+
+ public void test_superInInvalidContext_staticMethod() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " static m() {}",
+ "}",
+ "class B extends A {",
+ " static n() { return super.m(); }",
+ "}"));
+ resolve(source);
+ assertErrors(CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT);
+ // no verify(), 'super.m' is not resolved
+ }
+
+ public void test_superInInvalidContext_staticVariableInitializer() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " static a = 0;",
+ "}",
+ "class B extends A {",
+ " static b = super.a;",
+ "}"));
+ resolve(source);
+ assertErrors(CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT);
+ // no verify(), 'super.a' is not resolved
+ }
+
+ public void test_superInInvalidContext_topLevelFunction() throws Exception {
+ Source source = addSource(createSource(//
+ "f() {",
+ " super.f();",
+ "}"));
+ resolve(source);
+ assertErrors(CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT);
+ // no verify(), 'super.f' is not resolved
+ }
+
+ public void test_superInInvalidContext_topLevelVariableInitializer() throws Exception {
+ Source source = addSource(createSource(//
+ "var v = super.v;"));
+ resolve(source);
+ assertErrors(CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT);
+ // no verify(), 'super.v' is not resolved
+ }
+
public void test_undefinedClass_const() throws Exception {
Source source = addSource(createSource(//
"f() {",

Powered by Google App Engine
This is Rietveld 408576698