Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 14605006: Allows "Hello, world!" to run on ARM hardware. (Closed)

Created:
7 years, 7 months ago by zra
Modified:
7 years, 7 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allows "Hello, world!" to run on ARM hardware. Also, enables more vm tests on SIMMIPS. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=22344

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/assembler_arm.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/assembler_arm.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zra
Really great job on the ARM assembler, simulator, stubs, etc. for these to be the ...
7 years, 7 months ago (2013-05-02 22:25:15 UTC) #1
regis
LGTM Awesome! Thanks for testing this on ARM hardware. I actually introduced the bad conditional ...
7 years, 7 months ago (2013-05-02 22:32:40 UTC) #2
zra
Thanks! https://codereview.chromium.org/14605006/diff/1/runtime/vm/stub_code_arm.cc File runtime/vm/stub_code_arm.cc (right): https://codereview.chromium.org/14605006/diff/1/runtime/vm/stub_code_arm.cc#newcode1689 runtime/vm/stub_code_arm.cc:1689: // Return the current stack pointer address, used ...
7 years, 7 months ago (2013-05-02 22:58:40 UTC) #3
zra
7 years, 7 months ago (2013-05-02 22:58:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r22344 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698