Move pubspec caching into each source.

Move pubspec caching into each source.

This allows getVersion() to return a list of package IDs rather than a
list of pubspecs, which in turn will allow the Git source to return
resolved IDs in #1335.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/pub/commit/82fc67abedfda05b03e1018ecd0ada1cf68f937d

[nweiz, 2015-11-18 22:10:43]

nweiz@google.com changed reviewers:
+ rnystrom@google.com

[Bob Nystrom, 2015-11-19 23:43:55]

Couple of suggestions then LGTM!

https://codereview.chromium.org/1459733002/diff/1/lib/src/solver/backtracking...
File lib/src/solver/backtracking_solver.dart (right):

https://codereview.chromium.org/1459733002/diff/1/lib/src/solver/backtracking...
lib/src/solver/backtracking_solver.dart:122: final Pubspec _implicitPubspec =
(() {
Nit, I don't think the parens around the entire fn are needed.

https://codereview.chromium.org/1459733002/diff/1/lib/src/solver/version_solv...
File lib/src/solver/version_solver.dart (right):

https://codereview.chromium.org/1459733002/diff/1/lib/src/solver/version_solv...
lib/src/solver/version_solver.dart:137: class SolverCache {
Maybe "VersionsCache" or "VersionCache"?

https://codereview.chromium.org/1459733002/diff/1/lib/src/solver/version_solv...
lib/src/solver/version_solver.dart:206: : Version.prioritize(id1.version,
id2.version);
Swap the arguments here and get rid of the .reversed below.

[nweiz, 2015-11-24 01:32:28]

Code review changes

[nweiz, 2015-11-24 01:32:53]

https://codereview.chromium.org/1459733002/diff/1/lib/src/solver/backtracking...
File lib/src/solver/backtracking_solver.dart (right):

https://codereview.chromium.org/1459733002/diff/1/lib/src/solver/backtracking...
lib/src/solver/backtracking_solver.dart:122: final Pubspec _implicitPubspec =
(() {
On 2015/11/19 23:43:55, Bob Nystrom wrote:
> Nit, I don't think the parens around the entire fn are needed.

Done.

https://codereview.chromium.org/1459733002/diff/1/lib/src/solver/version_solv...
File lib/src/solver/version_solver.dart (right):

https://codereview.chromium.org/1459733002/diff/1/lib/src/solver/version_solv...
lib/src/solver/version_solver.dart:206: : Version.prioritize(id1.version,
id2.version);
On 2015/11/19 23:43:55, Bob Nystrom wrote:
> Swap the arguments here and get rid of the .reversed below.

Done.

[nweiz, 2015-11-24 01:33:05]

Committed patchset #2 (id:20001) manually as
82fc67abedfda05b03e1018ecd0ada1cf68f937d (presubmit successful).