Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: lib/src/validator/dependency.dart

Issue 1459733002: Move pubspec caching into each source. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/source/hosted.dart ('k') | test/version_solver_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/validator/dependency.dart
diff --git a/lib/src/validator/dependency.dart b/lib/src/validator/dependency.dart
index 8e8ea84a85a1dd7ca5493ee26ee85baee345423d..8f09cdbb37ff36b9db40588b7debd51fbecc6c37 100644
--- a/lib/src/validator/dependency.dart
+++ b/lib/src/validator/dependency.dart
@@ -67,9 +67,9 @@ class DependencyValidator extends Validator {
Future _warnAboutSource(PackageDep dep) async {
var versions;
try {
- var pubspecs = await entrypoint.cache.sources['hosted']
- .getVersions(dep.name, dep.name);
- versions = pubspecs.map((pubspec) => pubspec.version).toList();
+ var ref = new PackageRef(dep.name, 'hosted', dep.name);
+ var ids = await entrypoint.cache.sources['hosted'].getVersions(ref);
+ versions = ids.map((id) => id.version).toList();
} catch (error) {
versions = [];
}
« no previous file with comments | « lib/src/source/hosted.dart ('k') | test/version_solver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698