Issue 145633008: Ensure that a locked git dependency is downloaded correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 145633008: Ensure that a locked git dependency is downloaded correctly. (Closed)

Created:
6 years, 10 months ago by nweiz

Modified:
6 years, 10 months ago

Reviewers:
Bob Nystrom, Alan Knight

CC:
reviews_dartlang.org, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Ensure that a locked git dependency is downloaded correctly. Previously, if a git dependency's version was locked but its repo wasn't available locally, attempting to download it would crash pub. This also enhances some logging infrastructure around git and other processes. R=alanknight@google.com BUG=16470 Committed: https://code.google.com/p/dart/source/detail?r=32264

Patch Set 1 #

Patch Set 2 : forgot the test #

Created: 6 years, 10 months ago

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -15 lines)
M	sdk/lib/_internal/pub/lib/src/git.dart	View	2 chunks	+11 lines, -2 lines	0 comments
M	sdk/lib/_internal/pub/lib/src/io.dart	View	1 chunk	+1 line, -1 line	0 comments
M	sdk/lib/_internal/pub/lib/src/log.dart	View	3 chunks	+12 lines, -8 lines	0 comments
M	sdk/lib/_internal/pub/lib/src/source/git.dart	View	1 chunk	+3 lines, -2 lines	0 comments
A +	sdk/lib/_internal/pub/test/get/git/locked_revision_without_repo_test.dart	View	2 chunks	+6 lines, -2 lines	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

Committed patchset #2 manually as r32264 (presubmit successful).

6 years, 10 months ago (2014-02-03 22:27:16 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages