sdk/lib/_internal/pub/lib/src/source/git.dart - Issue 145633008: Ensure that a locked git dependency is downloaded correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/source/git.dart

Issue 145633008: Ensure that a locked git dependency is downloaded correctly. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: forgot the test Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/log.dart ('k') | sdk/lib/_internal/pub/test/get/git/locked_revision_without_repo_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/lib/src/source/git.dart

diff --git a/sdk/lib/_internal/pub/lib/src/source/git.dart b/sdk/lib/_internal/pub/lib/src/source/git.dart

index c50e7196c97b3b0caf3407e886d7afe79e6bcd44..2981ebe42f6f8a27073a5f7c9fc61a853bb8e370 100644

--- a/sdk/lib/_internal/pub/lib/src/source/git.dart

+++ b/sdk/lib/_internal/pub/lib/src/source/git.dart

@@ -130,8 +130,9 @@ class GitSource extends Source {

/// Returns a future that completes to the revision hash of [id].

Future<String> _revisionAt(PackageId id) {

- return git.run(["rev-parse", _getEffectiveRef(id)],

- workingDir: _repoCachePath(id)).then((result) => result[0]);

+ return _ensureRepoCache(id).then((_) =>

+ git.run(["rev-parse", _getEffectiveRef(id)],

+ workingDir: _repoCachePath(id)).then((result) => result[0]));

}

/// Clones the repo at the URI [from] to the path [to] on the local