Restore feature defines argument.

Restore feature defines argument.

R=podivlov@chromium.org

Committed: https://code.google.com/p/dart/source/detail?r=22065

[podivilov1, 2013-04-26 08:10:30]

lgtm

https://codereview.chromium.org/14416015/diff/1/tools/dom/scripts/fremontcutb...
File tools/dom/scripts/fremontcutbuilder.py (right):

https://codereview.chromium.org/14416015/diff/1/tools/dom/scripts/fremontcutb...
tools/dom/scripts/fremontcutbuilder.py:72: feature_defs = FEATURE_DEFINES
Maybe make FEATURE_DEFINES a default?

[podivilov1, 2013-04-26 08:11:23]

https://codereview.chromium.org/14416015/diff/1/tools/dom/scripts/fremontcutb...
File tools/dom/scripts/fremontcutbuilder.py (right):

https://codereview.chromium.org/14416015/diff/1/tools/dom/scripts/fremontcutb...
tools/dom/scripts/fremontcutbuilder.py:50: def build_database(idl_files,
database_dir, feature_defs=None, parallel=False):
nit: feature_defines

[Anton Muhin, 2013-04-26 08:25:49]

https://codereview.chromium.org/14416015/diff/1/tools/dom/scripts/fremontcutb...
File tools/dom/scripts/fremontcutbuilder.py (right):

https://codereview.chromium.org/14416015/diff/1/tools/dom/scripts/fremontcutb...
tools/dom/scripts/fremontcutbuilder.py:50: def build_database(idl_files,
database_dir, feature_defs=None, parallel=False):
On 2013/04/26 08:11:23, podivilov1 wrote:
> nit: feature_defines

Done.

https://codereview.chromium.org/14416015/diff/1/tools/dom/scripts/fremontcutb...
tools/dom/scripts/fremontcutbuilder.py:72: feature_defs = FEATURE_DEFINES
On 2013/04/26 08:10:30, podivilov1 wrote:
> Maybe make FEATURE_DEFINES a default?

Usually it's not recommended to have mutable objects as default in python as if
you mutate it, those mutations persist.

Yes, we're in full control here, but maybe follow common practices?

[Anton Muhin, 2013-04-26 08:27:11]

Committed patchset #2 manually as r22065 (presubmit successful).