Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Issue 14403004: Fix a couple of issues with dart2js typeddata. Add Uint64List and Int64List from typeddata. They ar… (Closed)

Created:
7 years, 8 months ago by Mads Ager (google)
Modified:
7 years, 8 months ago
Reviewers:
vsm, Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix a couple of issues with dart2js typeddata. Add Uint64List and Int64List from typeddata. They are unimplemented. Mark one test as passing on d8 (because the code doesn't do anything). R=antonm@google.com, vsm@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21794

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M sdk/lib/typeddata/dart2js/typeddata_dart2js.dart View 1 chunk +35 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mads Ager (google)
7 years, 8 months ago (2013-04-22 09:26:47 UTC) #1
Mads Ager (google)
Committed patchset #1 manually as r21794 (presubmit successful).
7 years, 8 months ago (2013-04-22 09:27:04 UTC) #2
Mads Ager (google)
tbr
7 years, 8 months ago (2013-04-22 09:27:06 UTC) #3
Anton Muhin
lgtm
7 years, 8 months ago (2013-04-22 09:57:00 UTC) #4
vsm
7 years, 8 months ago (2013-04-23 16:13:30 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698