Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: sdk/lib/typeddata/dart2js/typeddata_dart2js.dart

Issue 14403004: Fix a couple of issues with dart2js typeddata. Add Uint64List and Int64List from typeddata. They ar… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/html/html.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/typeddata/dart2js/typeddata_dart2js.dart
diff --git a/sdk/lib/typeddata/dart2js/typeddata_dart2js.dart b/sdk/lib/typeddata/dart2js/typeddata_dart2js.dart
index bfe1cd271d7be31b03e7eb7cb1768ee2428eb545..49a1ab0041ba5a0feacef1261f3808fe15d2f0fa 100644
--- a/sdk/lib/typeddata/dart2js/typeddata_dart2js.dart
+++ b/sdk/lib/typeddata/dart2js/typeddata_dart2js.dart
@@ -2214,6 +2214,41 @@ class Uint8List extends TypedData implements JavaScriptIndexingBehavior, List<in
// -- end List<int> mixins.
}
+
+class Int64List extends TypedData implements JavaScriptIndexingBehavior, List<int> {
+ factory Int64List(int length) {
+ throw new UnsupportedError("Int64List not supported by dart2js.");
+ }
+
+ factory Int64List.fromList(List<int> list) {
+ throw new UnsupportedError("Int64List not supported by dart2js.");
+ }
+
+ factory Int64List.view(ByteBuffer buffer, [int byteOffset, int length]) {
+ throw new UnsupportedError("Int64List not supported by dart2js.");
+ }
+
+ static const int BYTES_PER_ELEMENT = 8;
+}
+
+
+class Uint64List extends TypedData implements JavaScriptIndexingBehavior, List<int> {
+ factory Int64List(int length) {
+ throw new UnsupportedError("Int64List not supported by dart2js.");
+ }
+
+ factory Int64List.fromList(List<int> list) {
+ throw new UnsupportedError("Int64List not supported by dart2js.");
+ }
+
+ factory Int64List.view(ByteBuffer buffer, [int byteOffset, int length]) {
+ throw new UnsupportedError("Int64List not supported by dart2js.");
+ }
+
+ static const int BYTES_PER_ELEMENT = 8;
+}
+
+
// TODO(vsm): Eliminate this class and just inline into above.
class _TypedArrayFactoryProvider {
static ByteData createByteData(int length) => _B8(length);
« no previous file with comments | « no previous file | tests/html/html.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698