Code coverage in Observatory

Code coverage in Observatory

R=turnidge@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31970

[Cutch, 2014-01-21 18:35:35]

Couple side quests were tackled in this CL.

https://codereview.chromium.org/143973005/diff/1/runtime/bin/vmservice/client...
File
runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_profile.html
(left):

https://codereview.chromium.org/143973005/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_profile.html:35:
<blockquote><strong>Top Inclusive</strong></blockquote>
Tangent to this CL: Remove inclusive profile data display.

https://codereview.chromium.org/143973005/diff/1/runtime/bin/vmservice/client...
File
runtime/bin/vmservice/client/lib/src/observatory_elements/response_viewer.html
(left):

https://codereview.chromium.org/143973005/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/lib/src/observatory_elements/response_viewer.html:11:
<collapsible-content>
Tangent to this CL: Remove the "Raw message..." button at the bottom.

[turnidge, 2014-01-21 23:34:40]

lgtm with comments

https://codereview.chromium.org/143973005/diff/1/runtime/bin/vmservice/client...
File runtime/bin/vmservice/client/lib/src/observatory/model.dart (right):

https://codereview.chromium.org/143973005/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/lib/src/observatory/model.dart:255: bool get
covered => hits > 0;
the names "coverage" and "covered" are a bit similar and could be confusing. 
Maybe be more explicit.

https://codereview.chromium.org/143973005/diff/1/runtime/vm/coverage.cc
File runtime/vm/coverage.cc (right):

https://codereview.chromium.org/143973005/diff/1/runtime/vm/coverage.cc#newco...
runtime/vm/coverage.cc:199: }
Consider adding a test for this directly.

https://codereview.chromium.org/143973005/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/143973005/diff/1/runtime/vm/service.cc#newcod...
runtime/vm/service.cc:1049: return true;
Add a test.

[Cutch, 2014-01-22 00:47:25]

Committed patchset #2 manually as r31970 (presubmit successful).

[Cutch, 2014-01-22 00:50:37]

Forgot to publish these before submitting.

https://codereview.chromium.org/143973005/diff/1/runtime/bin/vmservice/client...
File runtime/bin/vmservice/client/lib/src/observatory/model.dart (right):

https://codereview.chromium.org/143973005/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/lib/src/observatory/model.dart:255: bool get
covered => hits > 0;
On 2014/01/21 23:34:40, turnidge wrote:
> the names "coverage" and "covered" are a bit similar and could be confusing. 
> Maybe be more explicit.

Agreed. I've gone with "executable" and "covered". Executable meaning the line
has executable code on it and covered meaning we've executed that line.

https://codereview.chromium.org/143973005/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/143973005/diff/1/runtime/vm/service.cc#newcod...
runtime/vm/service.cc:1049: return true;
On 2014/01/21 23:34:40, turnidge wrote:
> Add a test.

I added a test for HandleCoverage which also verifies that the coverage
information for the test script is correct.