Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/script_view.dart

Issue 143973005: Code coverage in Observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/observatory_elements/script_view.dart
diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/script_view.dart b/runtime/bin/vmservice/client/lib/src/observatory_elements/script_view.dart
index 2b8550e761e0c949d9f69c9a38e0b9b0024637f6..9125fc8124fc0602e6bcab2eda26ff851a6ededf 100644
--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/script_view.dart
+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/script_view.dart
@@ -4,13 +4,41 @@
library script_view_element;
+import 'dart:html';
+import 'package:logging/logging.dart';
import 'package:polymer/polymer.dart';
import 'observatory_element.dart';
/// Displays an Error response.
@CustomTag('script-view')
class ScriptViewElement extends ObservatoryElement {
- @published Map script;
+ @published Script script;
+
+ String hitsStyle(ScriptLine line) {
+ if (line.hits == -1) {
+ return 'min-width:32px;';
+ } else if (line.hits == 0) {
+ return 'min-width:32px;background-color:red';
+ }
+ return 'min-width:32px;background-color:green';
+ }
+
+ void refreshCoverage(Event e, var detail, Node target) {
+ var isolateId = app.locationManager.currentIsolateId();
+ var isolate = app.isolateManager.getIsolate(isolateId);
+ if (isolate == null) {
+ Logger.root.info('No isolate found.');
+ return;
+ }
+ var request = '/$isolateId/coverage';
+ app.requestManager.requestMap(request).then((Map coverage) {
+ assert(coverage['type'] == 'CodeCoverage');
+ isolate.updateCoverage(coverage['coverage']);
+ notifyPropertyChange(#hitsStyle, "", hitsStyle);
+ }).catchError((e, st) {
+ print('refreshCoverage $e $st');
+ });
+ }
ScriptViewElement.created() : super.created();
}

Powered by Google App Engine
This is Rietveld 408576698