Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 14383016: Move negative length checks from Dart into the native. (Closed)

Created:
7 years, 8 months ago by srdjan
Modified:
7 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move negative length checks from Dart into the native. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=22096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -121 lines) Patch
M runtime/lib/typed_data.cc View 2 chunks +6 lines, -1 line 0 comments Download
M runtime/lib/typed_data.dart View 24 chunks +0 lines, -96 lines 0 comments Download
M runtime/vm/flow_graph_builder.h View 1 chunk +12 lines, -12 lines 0 comments Download
M runtime/vm/intrinsifier.h View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
7 years, 8 months ago (2013-04-26 22:15:23 UTC) #1
siva
lgtm
7 years, 8 months ago (2013-04-26 23:45:09 UTC) #2
srdjan
7 years, 8 months ago (2013-04-27 00:04:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22096 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698