Move negative length checks from Dart into the native.

runtime/lib/typed_data.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // patch classes for Int8List ..... Float64List and ByteData implementations.
 
 patch class Int8List {
   /* patch */ factory Int8List(int length) {
     return new _Int8Array(length);
   }
@@ skipping 561 matching lines @@
   Float32x4 _getFloat32x4(int offsetInBytes) native "TypedData_GetFloat32x4";
   void _setFloat32x4(int offsetInBytes, Float32x4 value)
       native "TypedData_SetFloat32x4";
 }
 
 
 class _Int8Array extends _TypedList implements Int8List {
   // Factory constructors.
 
   factory _Int8Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
   factory _Int8Array.view(ByteBuffer buffer,
                           [int offsetInBytes = 0, int length]) {
     if (length == null) {
       length = buffer.lengthInBytes - offsetInBytes;
     }
     return new _Int8ArrayView(buffer, offsetInBytes, length);
   }
@@ skipping 34 matching lines @@
   }
 
   static _Int8Array _new(int length) native "TypedData_Int8Array_new";
 }
 
 
 class _Uint8Array extends _TypedList implements Uint8List {
   // Factory constructors.
 
   factory _Uint8Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
   factory _Uint8Array.view(ByteBuffer buffer,
                            [int offsetInBytes = 0, int length]) {
     if (length == null) {
       length = buffer.lengthInBytes - offsetInBytes;
     }
     return new _Uint8ArrayView(buffer, offsetInBytes, length);
   }
@@ skipping 32 matching lines @@
   }
 
   static _Uint8Array _new(int length) native "TypedData_Uint8Array_new";
 }
 
 
 class _Uint8ClampedArray extends _TypedList implements Uint8ClampedList {
   // Factory constructors.
 
   factory _Uint8ClampedArray(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
   factory _Uint8ClampedArray.view(ByteBuffer buffer,
                                   [int offsetInBytes = 0, int length]) {
     if (length == null) {
       length = buffer.lengthInBytes - offsetInBytes;
     }
     return new _Uint8ClampedArrayView(buffer, offsetInBytes, length);
   }
@@ skipping 34 matching lines @@
 
   static _Uint8ClampedArray _new(int length)
       native "TypedData_Uint8ClampedArray_new";
 }
 
 
 class _Int16Array extends _TypedList implements Int16List {
   // Factory constructors.
 
   factory _Int16Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
   factory _Int16Array.view(ByteBuffer buffer,
                            [int offsetInBytes = 0, int length]) {
     if (length == null) {
       length = (buffer.lengthInBytes - offsetInBytes) ~/
                Int16List.BYTES_PER_ELEMENT;
     }
     return new _Int16ArrayView(buffer, offsetInBytes, length);
@@ skipping 43 matching lines @@
   }
 
   static _Int16Array _new(int length) native "TypedData_Int16Array_new";
 }
 
 
 class _Uint16Array extends _TypedList implements Uint16List {
   // Factory constructors.
 
   factory _Uint16Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
   factory _Uint16Array.view(ByteBuffer buffer,
                             [int offsetInBytes = 0, int length]) {
     if (length == null) {
       length = (buffer.lengthInBytes - offsetInBytes) ~/
                 Uint16List.BYTES_PER_ELEMENT;
     }
     return new _Uint16ArrayView(buffer, offsetInBytes, length);
@@ skipping 43 matching lines @@
   }
 
   static _Uint16Array _new(int length) native "TypedData_Uint16Array_new";
 }
 
 
 class _Int32Array extends _TypedList implements Int32List {
   // Factory constructors.
 
   factory _Int32Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
   factory _Int32Array.view(ByteBuffer buffer,
                            [int offsetInBytes = 0, int length]) {
     if (length == null) {
       length = (buffer.lengthInBytes - offsetInBytes) ~/
                 Int32List.BYTES_PER_ELEMENT;
     }
     return new _Int32ArrayView(buffer, offsetInBytes, length);
@@ skipping 43 matching lines @@
   }
 
   static _Int32Array _new(int length) native "TypedData_Int32Array_new";
 }
 
 
 class _Uint32Array extends _TypedList implements Uint32List {
   // Factory constructors.
 
   factory _Uint32Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
   factory _Uint32Array.view(ByteBuffer buffer,
                             [int offsetInBytes = 0, int length]) {
     if (length == null) {
       length = (buffer.lengthInBytes - offsetInBytes) ~/
                 Uint32List.BYTES_PER_ELEMENT;
     }
     return new _Uint32ArrayView(buffer, offsetInBytes, length);
@@ skipping 43 matching lines @@
   }
 
   static _Uint32Array _new(int length) native "TypedData_Uint32Array_new";
 }
 
 
 class _Int64Array extends _TypedList implements Int64List {
   // Factory constructors.
 
   factory _Int64Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
   factory _Int64Array.view(ByteBuffer buffer,
                            [int offsetInBytes = 0, int length]) {
     if (length == null) {
       length = (buffer.lengthInBytes - offsetInBytes) ~/
                 Int32List.BYTES_PER_ELEMENT;
     }
     return new _Int64ArrayView(buffer, offsetInBytes, length);
@@ skipping 43 matching lines @@
   }
 
   static _Int64Array _new(int length) native "TypedData_Int64Array_new";
 }
 
 
 class _Uint64Array extends _TypedList implements Uint64List {
   // Factory constructors.
 
   factory _Uint64Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
   factory _Uint64Array.view(ByteBuffer buffer,
                             [int offsetInBytes = 0, int length]) {
     if (length == null) {
       length = (buffer.lengthInBytes - offsetInBytes) ~/
                Uint64List.BYTES_PER_ELEMENT;
     }
     return new _Uint64ArrayView(buffer, offsetInBytes, length);
@@ skipping 43 matching lines @@
   }
 
   static _Uint64Array _new(int length) native "TypedData_Uint64Array_new";
 }
 
 
 class _Float32Array extends _TypedList implements Float32List {
   // Factory constructors.
 
   factory _Float32Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
   factory _Float32Array.view(ByteBuffer buffer,
                              [int offsetInBytes = 0, int length]) {
     if (length == null) {
       length = (buffer.lengthInBytes - offsetInBytes) ~/
                Float32List.BYTES_PER_ELEMENT;
     }
     return new _Float32ArrayView(buffer, offsetInBytes, length);
@@ skipping 43 matching lines @@
   }
 
   static _Float32Array _new(int length) native "TypedData_Float32Array_new";
 }
 
 
 class _Float64Array extends _TypedList implements Float64List {
   // Factory constructors.
 
   factory _Float64Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
   factory _Float64Array.view(ByteBuffer buffer,
                              [int offsetInBytes = 0, int length]) {
     if (length == null) {
       length = (buffer.lengthInBytes - offsetInBytes) ~/
                Float64List.BYTES_PER_ELEMENT;
     }
     return new _Float64ArrayView(buffer, offsetInBytes, length);
@@ skipping 42 matching lines @@
     _setFloat64(index * Float64List.BYTES_PER_ELEMENT, value);
   }
 
   static _Float64Array _new(int length) native "TypedData_Float64Array_new";
 }
 
 class _Float32x4Array extends _TypedList implements Float32x4List {
   // Factory constructors.
 
   factory _Float32x4Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
   factory _Float32x4Array.view(ByteBuffer buffer,
                                [int offsetInBytes = 0, int length]) {
     if (length == null) {
       length = (buffer.lengthInBytes - offsetInBytes) ~/
                Float32x4List.BYTES_PER_ELEMENT;
     }
     return new _Float32x4ArrayView(buffer, offsetInBytes, length);
@@ skipping 41 matching lines @@
   }
 
   static _Float32x4Array _new(int length) native "TypedData_Float32x4Array_new";
 }
 
 
 class _ExternalInt8Array extends _TypedList implements Int8List {
   // Factory constructors.
 
   factory _ExternalInt8Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
 
   // Method(s) implementing the List interface.
   int operator[](int index) {
     if (index < 0 || index >= length) {
       _throwRangeError(index, length);
     }
     return _getInt8(index);
@@ skipping 26 matching lines @@
 
   static _ExternalInt8Array _new(int length) native
       "ExternalTypedData_Int8Array_new";
 }
 
 
 class _ExternalUint8Array extends _TypedList implements Uint8List {
   // Factory constructors.
 
   factory _ExternalUint8Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
 
   // Method(s) implementing the List interface.
 
   int operator[](int index) {
     if (index < 0 || index >= length) {
       _throwRangeError(index, length);
     }
@@ skipping 27 matching lines @@
 
   static _ExternalUint8Array _new(int length) native
       "ExternalTypedData_Uint8Array_new";
 }
 
 
 class _ExternalUint8ClampedArray extends _TypedList implements Uint8ClampedList {
   // Factory constructors.
 
   factory _ExternalUint8ClampedArray(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
 
   // Method(s) implementing the List interface.
 
   int operator[](int index) {
     if (index < 0 || index >= length) {
       _throwRangeError(index, length);
     }
@@ skipping 27 matching lines @@
 
   static _ExternalUint8ClampedArray _new(int length) native
       "ExternalTypedData_Uint8ClampedArray_new";
 }
 
 
 class _ExternalInt16Array extends _TypedList implements Int16List {
   // Factory constructors.
 
   factory _ExternalInt16Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
 
   // Method(s) implementing the List interface.
 
   int operator[](int index) {
     if (index < 0 || index >= length) {
       _throwRangeError(index, length);
     }
@@ skipping 35 matching lines @@
 
   static _ExternalInt16Array _new(int length) native
       "ExternalTypedData_Int16Array_new";
 }
 
 
 class _ExternalUint16Array extends _TypedList implements Uint16List {
   // Factory constructors.
 
   factory _ExternalUint16Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
 
   // Method(s) implementing the List interface.
 
   int operator[](int index) {
     if (index < 0 || index >= length) {
       _throwRangeError(index, length);
     }
@@ skipping 35 matching lines @@
 
   static _ExternalUint16Array _new(int length) native
       "ExternalTypedData_Uint16Array_new";
 }
 
 
 class _ExternalInt32Array extends _TypedList implements Int32List {
   // Factory constructors.
 
   factory _ExternalInt32Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
 
   // Method(s) implementing the List interface.
 
   int operator[](int index) {
     if (index < 0 || index >= length) {
       _throwRangeError(index, length);
     }
@@ skipping 35 matching lines @@
 
   static _ExternalInt32Array _new(int length) native
       "ExternalTypedData_Int32Array_new";
 }
 
 
 class _ExternalUint32Array extends _TypedList implements Uint32List {
   // Factory constructors.
 
   factory _ExternalUint32Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
 
   // Method(s) implementing the List interface.
 
   int operator[](int index) {
     if (index < 0 || index >= length) {
       _throwRangeError(index, length);
     }
@@ skipping 35 matching lines @@
 
   static _ExternalUint32Array _new(int length) native
       "ExternalTypedData_Uint32Array_new";
 }
 
 
 class _ExternalInt64Array extends _TypedList implements Int64List {
   // Factory constructors.
 
   factory _ExternalInt64Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
 
   // Method(s) implementing the List interface.
 
   int operator[](int index) {
     if (index < 0 || index >= length) {
       _throwRangeError(index, length);
     }
@@ skipping 35 matching lines @@
 
   static _ExternalInt64Array _new(int length) native
       "ExternalTypedData_Int64Array_new";
 }
 
 
 class _ExternalUint64Array extends _TypedList implements Uint64List {
   // Factory constructors.
 
   factory _ExternalUint64Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
 
   // Method(s) implementing the List interface.
 
   int operator[](int index) {
     if (index < 0 || index >= length) {
       _throwRangeError(index, length);
     }
@@ skipping 35 matching lines @@
 
   static _ExternalUint64Array _new(int length) native
       "ExternalTypedData_Uint64Array_new";
 }
 
 
 class _ExternalFloat32Array extends _TypedList implements Float32List {
   // Factory constructors.
 
   factory _ExternalFloat32Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
 
   // Method(s) implementing the List interface.
 
   double operator[](int index) {
     if (index < 0 || index >= length) {
       _throwRangeError(index, length);
     }
@@ skipping 35 matching lines @@
 
   static _ExternalFloat32Array _new(int length) native
       "ExternalTypedData_Float32Array_new";
 }
 
 
 class _ExternalFloat64Array extends _TypedList implements Float64List {
   // Factory constructors.
 
   factory _ExternalFloat64Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
 
   // Method(s) implementing the List interface.
 
   double operator[](int index) {
     if (index < 0 || index >= length) {
       _throwRangeError(index, length);
     }
@@ skipping 35 matching lines @@
 
   static _ExternalFloat64Array _new(int length) native
       "ExternalTypedData_Float64Array_new";
 }
 
 
 class _ExternalFloat32x4Array extends _TypedList implements Float32x4List {
   // Factory constructors.
 
   factory _ExternalFloat32x4Array(int length) {
-    if (length < 0) {
-      String message = "$length must be greater than 0";
-      throw new ArgumentError(message);
-    }
     return _new(length);
   }
 
 
   // Method(s) implementing the List interface.
 
   Float32x4 operator[](int index) {
     if (index < 0 || index >= length) {
       _throwRangeError(index, length);
     }
@@ skipping 1209 matching lines @@
     return value;
   }
   return object;
 }
 
 
 void _throwRangeError(int index, int length) {
   String message = "$index must be in the range [0..$length)";
   throw new RangeError(message);
 }