Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 14366007: Handle built-in function identical correctly (Closed)

Created:
7 years, 8 months ago by hausner
Modified:
7 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle built-in function identical correctly The parser, rather than the backend, recognizes the built-in function identical and replaces is with the old token for the === operator. This fixes compile time constant handling of calls to identical. Committed: https://code.google.com/p/dart/source/detail?r=21753

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -31 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 3 chunks +0 lines, -4 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
7 years, 8 months ago (2013-04-18 23:09:26 UTC) #1
srdjan
lgtm
7 years, 8 months ago (2013-04-18 23:32:10 UTC) #2
hausner
7 years, 8 months ago (2013-04-19 16:26:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21753 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698