Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: runtime/vm/parser.cc

Issue 14366007: Handle built-in function identical correctly (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | tests/co19/co19-dart2dart.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 21709)
+++ runtime/vm/parser.cc (working copy)
@@ -7350,6 +7350,16 @@
func_name,
InvocationMirror::kStatic,
InvocationMirror::kMethod);
+ } else if (cls.IsTopLevel() &&
+ (cls.library() == Library::CoreLibrary()) &&
+ (func.name() == Symbols::Identical().raw())) {
+ // This is the predefined toplevel function identical(a,b). Create
+ // a comparison node instead.
+ ASSERT(num_arguments == 2);
+ return new ComparisonNode(ident_pos,
+ Token::kEQ_STRICT,
+ arguments->NodeAt(0),
+ arguments->NodeAt(1));
}
return new StaticCallNode(call_pos, func, arguments);
}
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | tests/co19/co19-dart2dart.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698