Issue 14348005: Fix for issue 9617, throw a snapshot write error when encountering stacktrace objects instead of an…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14348005: Fix for issue 9617, throw a snapshot write error when encountering stacktrace objects instead of an… (Closed)

Created:
7 years, 8 months ago by siva

Modified:
7 years, 8 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix for issue 9617, throw a snapshot write error when encountering stacktrace objects instead of an internal error. Committed: https://code.google.com/p/dart/source/detail?r=21709

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -10 lines)			Patch
M	runtime/vm/raw_object_snapshot.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/vm/snapshot.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View		1 chunk	+13 lines, -9 lines	0 comments	Download
A	tests/isolate/stacktrace_message_test.dart	View		1 chunk	+25 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

siva

7 years, 8 months ago (2013-04-18 22:59:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21709 (presubmit successful).