Fix for issue 9617, throw a snapshot write error when encountering stacktrace objects instead of an…

runtime/vm/snapshot.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/snapshot.h"
 
 #include "platform/assert.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
 #include "vm/class_finalizer.h"
@@ skipping 1300 matching lines @@
   // Write out the individual object ids.
   for (intptr_t i = 0; i < len; i++) {
     WriteObjectRef(data[i]);
   }
 }
 
 
 void SnapshotWriter::CheckIfSerializable(RawClass* cls) {
   if (Class::IsSignatureClass(cls)) {
     // We do not allow closure objects in an isolate message.
-    set_exception_type(Exceptions::kArgument);
-    // TODO(6726): Allocate these constant strings once in the VM isolate.
-    set_exception_msg("Illegal argument in isolate message"
+    SetWriteException(Exceptions::kArgument,
+                      "Illegal argument in isolate message"
                       " : (object is a closure)");
-    Isolate::Current()->long_jump_base()->Jump(1, *ErrorHandle());
   }
   if (cls->ptr()->num_native_fields_ != 0) {
     // We do not allow objects with native fields in an isolate message.
-    set_exception_type(Exceptions::kArgument);
-    // TODO(6726): Allocate these constant strings once in the VM isolate.
-    set_exception_msg("Illegal argument in isolate message"
+    SetWriteException(Exceptions::kArgument,
+                      "Illegal argument in isolate message"
                       " : (object extends NativeWrapper)");
+  }
+}
 
-    Isolate::Current()->long_jump_base()->Jump(1, *ErrorHandle());
-  }
+
+void SnapshotWriter::SetWriteException(Exceptions::ExceptionType type,
+                                       const char* msg) {
+  set_exception_type(type);
+  // TODO(6726): Allocate these constant strings once in the VM isolate.
+  set_exception_msg(msg);
+  Isolate::Current()->long_jump_base()->Jump(1, *ErrorHandle());
 }
 
 
 void SnapshotWriter::WriteInstance(intptr_t object_id,
                                    RawObject* raw,
                                    RawClass* cls,
                                    intptr_t tags) {
   // First check if object is a closure or has native fields.
   CheckIfSerializable(cls);
 
@@ skipping 116 matching lines @@
     UnmarkAll();
     isolate->set_long_jump_base(base);
   } else {
     isolate->set_long_jump_base(base);
     ThrowException(exception_type(), exception_msg());
   }
 }
 
 
 }  // namespace dart