Make source mirror ObjectMirror.getField synchronous

Make source mirror ObjectMirror.getField synchronous

Committed: https://code.google.com/p/dart/source/detail?r=22002

[Andrei Mouravski, 2013-04-24 22:32:40]

lgtm

Only comment is that maybe it's worth adding a line to description explaining
why this change.

https://codereview.chromium.org/14333011/diff/1/tools/dom/docs/lib/docs.dart
File tools/dom/docs/lib/docs.dart (left):

https://codereview.chromium.org/14333011/diff/1/tools/dom/docs/lib/docs.dart#...
tools/dom/docs/lib/docs.dart:183: var tags =
deprecatedFutureValue(domNameMetadata.getField('name'));
Yay!

[Johnni Winther, 2013-04-25 06:22:23]

On 2013/04/24 22:32:40, Andrei Mouravski wrote:
> lgtm
> 
> Only comment is that maybe it's worth adding a line to description explaining
> why this change.
> 
> https://codereview.chromium.org/14333011/diff/1/tools/dom/docs/lib/docs.dart
> File tools/dom/docs/lib/docs.dart (left):
> 
>
https://codereview.chromium.org/14333011/diff/1/tools/dom/docs/lib/docs.dart#...
> tools/dom/docs/lib/docs.dart:183: var tags =
> deprecatedFutureValue(domNameMetadata.getField('name'));
> Yay!

The change is made to align the source mirrors with the runtime mirror, which
recently have split getField (and setField and invoke) into a synchronous
getField and an asynchronous getFieldAsync.

[Johnni Winther, 2013-04-25 06:22:23]

On 2013/04/24 22:32:40, Andrei Mouravski wrote:
> lgtm
> 
> Only comment is that maybe it's worth adding a line to description explaining
> why this change.
> 
> https://codereview.chromium.org/14333011/diff/1/tools/dom/docs/lib/docs.dart
> File tools/dom/docs/lib/docs.dart (left):
> 
>
https://codereview.chromium.org/14333011/diff/1/tools/dom/docs/lib/docs.dart#...
> tools/dom/docs/lib/docs.dart:183: var tags =
> deprecatedFutureValue(domNameMetadata.getField('name'));
> Yay!

The change is made to align the source mirrors with the runtime mirror, which
recently have split getField (and setField and invoke) into a synchronous
getField and an asynchronous getFieldAsync.

[Johnni Winther, 2013-04-25 07:05:10]

Committed patchset #1 manually as r22002 (presubmit successful).