Make source mirror ObjectMirror.getField synchronous

tests/compiler/dart2js/mirrors_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "package:expect/expect.dart";
 import '../../../sdk/lib/_internal/compiler/implementation/mirrors/mirrors.dart';
 import '../../../sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart';
 import '../../../sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart';
 import '../../../sdk/lib/_internal/compiler/implementation/filenames.dart'
        show currentDirectory, nativeToUriPath;
@@ skipping 248 matching lines @@
       "// Singleline comment 2.", metadata.text);
   Expect.stringEquals(
       "Singleline comment 2.", metadata.trimmedText);
 
   // @Metadata(null)
   metadata = metadataList[metadataListIndex++];
   Expect.isTrue(metadata is InstanceMirror);
   Expect.isFalse(metadata.hasReflectee);
   Expect.throws(() => metadata.reflectee, (_) => true);
   Expect.equals(metadataType.originalDeclaration, metadata.type);
-  metadata.getField('data').then((InstanceMirror data) {
-    Expect.isNotNull(data);
-    Expect.isTrue(data.hasReflectee);
-    Expect.isNull(data.reflectee);
-  });
+  InstanceMirror data = metadata.getField('data');
+  Expect.isNotNull(data);
+  Expect.isTrue(data.hasReflectee);
+  Expect.isNull(data.reflectee);
 
   // @Metadata(true)
   metadata = metadataList[metadataListIndex++];
   Expect.isTrue(metadata is InstanceMirror);
   Expect.isFalse(metadata.hasReflectee);
   Expect.throws(() => metadata.reflectee, (_) => true);
   Expect.equals(metadataType.originalDeclaration, metadata.type);
-  metadata.getField('data').then((InstanceMirror data) {
-    Expect.isNotNull(data);
-    Expect.isTrue(data.hasReflectee);
-    Expect.isTrue(data.reflectee);
-  });
+  data = metadata.getField('data');
+  Expect.isNotNull(data);
+  Expect.isTrue(data.hasReflectee);
+  Expect.isTrue(data.reflectee);
 
   // @Metadata(false)
   metadata = metadataList[metadataListIndex++];
   Expect.isTrue(metadata is InstanceMirror);
   Expect.isFalse(metadata.hasReflectee);
   Expect.throws(() => metadata.reflectee, (_) => true);
   Expect.equals(metadataType.originalDeclaration, metadata.type);
-  metadata.getField('data').then((InstanceMirror data) {
-    Expect.isNotNull(data);
-    Expect.isTrue(data.hasReflectee);
-    Expect.isFalse(data.reflectee);
-  });
+  data = metadata.getField('data');
+  Expect.isNotNull(data);
+  Expect.isTrue(data.hasReflectee);
+  Expect.isFalse(data.reflectee);
 
   // @Metadata(0)
   metadata = metadataList[metadataListIndex++];
   Expect.isTrue(metadata is InstanceMirror);
   Expect.isFalse(metadata.hasReflectee);
   Expect.throws(() => metadata.reflectee, (_) => true);
   Expect.equals(metadataType.originalDeclaration, metadata.type);
-  metadata.getField('data').then((InstanceMirror data) {
-    Expect.isNotNull(data);
-    Expect.isTrue(data.hasReflectee);
-    Expect.equals(0, data.reflectee);
-  });
+  data = metadata.getField('data');
+  Expect.isNotNull(data);
+  Expect.isTrue(data.hasReflectee);
+  Expect.equals(0, data.reflectee);
 
   // @Metadata(1.5)
   metadata = metadataList[metadataListIndex++];
   Expect.isTrue(metadata is InstanceMirror);
   Expect.isFalse(metadata.hasReflectee);
   Expect.throws(() => metadata.reflectee, (_) => true);
   Expect.equals(metadataType.originalDeclaration, metadata.type);
-  metadata.getField('data').then((InstanceMirror data) {
-    Expect.isNotNull(data);
-    Expect.isTrue(data.hasReflectee);
-    Expect.equals(1.5, data.reflectee);
-  });
+  data = metadata.getField('data');
+  Expect.isNotNull(data);
+  Expect.isTrue(data.hasReflectee);
+  Expect.equals(1.5, data.reflectee);
 
   // @Metadata("Foo")
   metadata = metadataList[metadataListIndex++];
   Expect.isTrue(metadata is InstanceMirror);
   Expect.isFalse(metadata.hasReflectee);
   Expect.throws(() => metadata.reflectee, (_) => true);
   Expect.equals(metadataType.originalDeclaration, metadata.type);
-  metadata.getField('data').then((InstanceMirror data) {
-    Expect.isNotNull(data);
-    Expect.isTrue(data.hasReflectee);
-    Expect.stringEquals("Foo", data.reflectee);
-  });
+  data = metadata.getField('data');
+  Expect.isNotNull(data);
+  Expect.isTrue(data.hasReflectee);
+  Expect.stringEquals("Foo", data.reflectee);
 
   // @Metadata(const ["Foo"])
   metadata = metadataList[metadataListIndex++];
   Expect.isTrue(metadata is InstanceMirror);
   Expect.isFalse(metadata.hasReflectee);
   Expect.throws(() => metadata.reflectee, (_) => true);
   Expect.equals(metadataType.originalDeclaration, metadata.type);
-  metadata.getField('data').then((InstanceMirror data) {
-    Expect.isTrue(data is ListInstanceMirror);
-    Expect.isFalse(data.hasReflectee);
-    Expect.throws(() => data.reflectee, (_) => true);
-    ListInstanceMirror listData = data;
-    Expect.equals(1, listData.length);
-    listData[0].then((InstanceMirror element) {
-      Expect.isNotNull(element);
-      Expect.isTrue(element.hasReflectee);
-      Expect.stringEquals("Foo", element.reflectee);
-    });
-  });
+  data = metadata.getField('data');
+  Expect.isTrue(data is ListInstanceMirror);
+  Expect.isFalse(data.hasReflectee);
+  Expect.throws(() => data.reflectee, (_) => true);
+  ListInstanceMirror listData = data;
+  Expect.equals(1, listData.length);
+  InstanceMirror element = listData[0];
+  Expect.isNotNull(element);
+  Expect.isTrue(element.hasReflectee);
+  Expect.stringEquals("Foo", element.reflectee);
 
   // @Metadata(/* Inline comment */ const {'foo':"Foo"})
   metadata = metadataList[metadataListIndex++];
   Expect.isTrue(metadata is InstanceMirror);
   Expect.isFalse(metadata.hasReflectee);
   Expect.throws(() => metadata.reflectee, (_) => true);
   Expect.equals(metadataType.originalDeclaration, metadata.type);
-  metadata.getField('data').then((InstanceMirror data) {
-    Expect.isTrue(data is MapInstanceMirror);
-    Expect.isFalse(data.hasReflectee);
-    Expect.throws(() => data.reflectee, (_) => true);
-    MapInstanceMirror mapData = data;
-    Expect.equals(1, mapData.length);
-    var it = mapData.keys.iterator;
-    Expect.isTrue(it.moveNext());
-    Expect.stringEquals('foo', it.current);
-    mapData['foo'].then((InstanceMirror element) {
-      Expect.isNotNull(element);
-      Expect.isTrue(element.hasReflectee);
-      Expect.stringEquals("Foo", element.reflectee);
-    });
-    Expect.isNull(mapData['bar']);
-  });
+  data = metadata.getField('data');
+  Expect.isTrue(data is MapInstanceMirror);
+  Expect.isFalse(data.hasReflectee);
+  Expect.throws(() => data.reflectee, (_) => true);
+  MapInstanceMirror mapData = data;
+  Expect.equals(1, mapData.length);
+  var it = mapData.keys.iterator;
+  Expect.isTrue(it.moveNext());
+  Expect.stringEquals('foo', it.current);
+  element = mapData['foo'];
+  Expect.isNotNull(element);
+  Expect.isTrue(element.hasReflectee);
+  Expect.stringEquals("Foo", element.reflectee);
+  Expect.isNull(mapData['bar']);
 
   // @metadata
   metadata = metadataList[metadataListIndex++];
   Expect.isTrue(metadata is InstanceMirror);
   Expect.isFalse(metadata.hasReflectee);
   Expect.throws(() => metadata.reflectee, (_) => true);
   Expect.equals(metadataType.originalDeclaration, metadata.type);
-  metadata.getField('data').then((InstanceMirror data) {
-    Expect.isNotNull(data);
-    Expect.isTrue(data.hasReflectee);
-    Expect.isNull(data.reflectee);
-  });
+  data = metadata.getField('data');
+  Expect.isNotNull(data);
+  Expect.isTrue(data.hasReflectee);
+  Expect.isNull(data.reflectee);
 
   // /** Multiline doc comment. */
   metadata = metadataList[metadataListIndex++];
   Expect.isTrue(metadata is InstanceMirror);
   Expect.isFalse(metadata.hasReflectee);
   Expect.throws(() => metadata.reflectee, (_) => true);
   Expect.isTrue(metadata is CommentInstanceMirror);
   Expect.equals(commentType.originalDeclaration, metadata.type);
   Expect.isTrue(metadata.isDocComment);
   Expect.stringEquals(
@@ skipping 661 matching lines @@
   Expect.isTrue(privateFactoryConstructor.isPrivate);
   Expect.isFalse(privateFactoryConstructor.isConstConstructor);
   Expect.isFalse(privateFactoryConstructor.isRedirectingConstructor);
   Expect.isFalse(privateFactoryConstructor.isGenerativeConstructor);
   Expect.isTrue(privateFactoryConstructor.isFactoryConstructor);
 
   var metadata = privateClass.metadata;
   Expect.isNotNull(metadata);
   Expect.equals(0, metadata.length);
 }