Issue 14323003: Uncomment more vm tests on ARM (and some on MIPS too).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14323003: Uncomment more vm tests on ARM (and some on MIPS too). (Closed)

Created:
7 years, 8 months ago by regis

Modified:
7 years, 8 months ago

Reviewers:
zra

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Uncomment more vm tests on ARM (and some on MIPS too). Implement context allocation stub. Some cleanup. Committed: https://code.google.com/p/dart/source/detail?r=21626

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+146 lines, -21 lines)			Patch
M	runtime/tests/vm/vm.status	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/vm/benchmark_test.cc	View	1	2 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/custom_isolate_test.cc	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1	1 chunk	+17 lines, -3 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1	4 chunks	+115 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm https://codereview.chromium.org/14323003/diff/1/runtime/vm/stub_code_arm.cc File runtime/vm/stub_code_arm.cc (right): https://codereview.chromium.org/14323003/diff/1/runtime/vm/stub_code_arm.cc#newcode814 runtime/vm/stub_code_arm.cc:814: __ ldr(IP, Address(IP, 0)); Same mistake on MIPS ...

7 years, 8 months ago (2013-04-17 15:01:26 UTC) #2

regis

7 years, 8 months ago (2013-04-17 16:02:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21626 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14323003: Uncomment more vm tests on ARM (and some on MIPS too). (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages