runtime/vm/intrinsifier_ia32.cc - Issue 14323003: Uncomment more vm tests on ARM (and some on MIPS too).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 14323003: Uncomment more vm tests on ARM (and some on MIPS too). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intrinsifier_ia32.cc

===================================================================

--- runtime/vm/intrinsifier_ia32.cc (revision 21624)

+++ runtime/vm/intrinsifier_ia32.cc (working copy)

@@ -40,7 +40,7 @@

// RoundedAllocationSize((array_length * kwordSize) + sizeof(RawArray)).

__ movl(EDI, Address(ESP, kArrayLengthOffset)); // Array length.

// Check that length is a positive Smi.

- __ testl(EDI, Immediate(kSmiTagSize));

+ __ testl(EDI, Immediate(kSmiTagMask));

__ j(NOT_ZERO, &fall_through);

__ cmpl(EDI, Immediate(0));

__ j(LESS, &fall_through);

@@ -464,7 +464,7 @@

__ movl(EDI, Address(ESP, kArrayLengthStackOffset)); /* Array length. */ \

/* Check that length is a positive Smi. */ \

/* EDI: requested array length argument. */ \

- __ testl(EDI, Immediate(kSmiTagSize)); \

+ __ testl(EDI, Immediate(kSmiTagMask)); \

__ j(NOT_ZERO, &fall_through); \

__ cmpl(EDI, Immediate(0)); \

__ j(LESS, &fall_through); \

« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intrinsifier_x64.cc » ('j') | no next file with comments »