Issue 14307007: Fix crashes in debug mode with optimizations turned off.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14307007: Fix crashes in debug mode with optimizations turned off. (Closed)

Created:
7 years, 8 months ago by srdjan

Modified:
7 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix crashes in debug mode with optimizations turned off. Remove wrong assert. The correct assertion is done within SetTypeArguments. Committed: https://code.google.com/p/dart/source/detail?r=22079

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	runtime/lib/array.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
	M	runtime/lib/growable_array.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

Committed patchset #2 manually as r22079 (presubmit successful).

7 years, 8 months ago (2013-04-26 18:19:50 UTC) #3

regis

7 years, 7 months ago (2013-04-29 16:00:45 UTC) #4

Message was sent while issue was closed.

On 2013/04/26 18:19:50, srdjan wrote:
> Committed patchset #2 manually as r22079 (presubmit successful).

Thanks for fixing this, Srdjan. I missed it in my last cl.

Expand Messages | Collapse Messages