Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: runtime/lib/array.cc

Issue 14307007: Fix crashes in debug mode with optimizations turned off. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/lib/growable_array.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/assert.h" 5 #include "platform/assert.h"
6 #include "vm/bootstrap_natives.h" 6 #include "vm/bootstrap_natives.h"
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 #include "vm/bigint_operations.h" 8 #include "vm/bigint_operations.h"
9 #include "vm/exceptions.h" 9 #include "vm/exceptions.h"
10 #include "vm/native_entry.h" 10 #include "vm/native_entry.h"
11 #include "vm/object.h" 11 #include "vm/object.h"
12 12
13 namespace dart { 13 namespace dart {
14 14
15 DEFINE_NATIVE_ENTRY(ObjectArray_allocate, 2) { 15 DEFINE_NATIVE_ENTRY(ObjectArray_allocate, 2) {
16 const AbstractTypeArguments& type_arguments = 16 const AbstractTypeArguments& type_arguments =
17 AbstractTypeArguments::CheckedHandle(isolate, arguments->NativeArgAt(0)); 17 AbstractTypeArguments::CheckedHandle(isolate, arguments->NativeArgAt(0));
18 ASSERT(type_arguments.IsNull() ||
19 (type_arguments.IsInstantiated() && (type_arguments.Length() == 1)));
20 const Instance& length = Instance::CheckedHandle( 18 const Instance& length = Instance::CheckedHandle(
21 isolate, arguments->NativeArgAt(1)); 19 isolate, arguments->NativeArgAt(1));
22 if (!length.IsSmi()) { 20 if (!length.IsSmi()) {
23 const String& error = String::Handle(String::NewFormatted( 21 const String& error = String::Handle(String::NewFormatted(
24 "Length must be an integer in the range [0..%"Pd"].", 22 "Length must be an integer in the range [0..%"Pd"].",
25 Array::kMaxElements)); 23 Array::kMaxElements));
26 const Array& args = Array::Handle(Array::New(1)); 24 const Array& args = Array::Handle(Array::New(1));
27 args.SetAt(0, error); 25 args.SetAt(0, error);
28 Exceptions::ThrowByType(Exceptions::kArgument, args); 26 Exceptions::ThrowByType(Exceptions::kArgument, args);
29 } 27 }
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 } else { 108 } else {
111 for (intptr_t i = 0; i < icount; i++) { 109 for (intptr_t i = 0; i < icount; i++) {
112 src_obj = source.At(isrc_start + i); 110 src_obj = source.At(isrc_start + i);
113 dest.SetAt(idst_start + i, src_obj); 111 dest.SetAt(idst_start + i, src_obj);
114 } 112 }
115 } 113 }
116 return Object::null(); 114 return Object::null();
117 } 115 }
118 116
119 } // namespace dart 117 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/lib/growable_array.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698