Move pub into sdk/lib/_internal.

Move pub into sdk/lib/_internal.

This also converts pub to a more package-like layout, which will help in the
eventual exposing of pub internals as a library. Since pub's sources are now in
lib/src, this also makes them importable from the tests and entrypoint using
"package:" imports.

BUG=6619
Committed: https://code.google.com/p/dart/source/detail?r=21907

[Bob Nystrom, 2013-04-23 19:41:19]

https://codereview.chromium.org/14297021/diff/1/sdk/bin/pub
File sdk/bin/pub (right):

https://codereview.chromium.org/14297021/diff/1/sdk/bin/pub#newcode11
sdk/bin/pub:11: exec "$BIN_DIR"/dart --package-root="$DART_SDK"/packages/ \
In a separate patch, can you also move packages under lib/_internal too? I think
Dan wanted to see pub's internal package dependencies a little more hidden in
the SDK.

https://codereview.chromium.org/14297021/diff/1/sdk/lib/_internal/pub/bin/pub...
File sdk/lib/_internal/pub/bin/pub.dart (right):

https://codereview.chromium.org/14297021/diff/1/sdk/lib/_internal/pub/bin/pub...
sdk/lib/_internal/pub/bin/pub.dart:5: import 'package:pub/src/pub.dart';
Does this mean that you have to build the SDK before you can run pub from the
repo? If I'm hacking pub, is my iteration loop now:

1. Change code.
2. Build SDK. <-- new step
3. Run test.

?

https://codereview.chromium.org/14297021/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/pub.dart (right):

https://codereview.chromium.org/14297021/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/pub.dart:202: abstract class PubCommand {
Move this into its own file and then move the rest of this code to bin/pub.dart?

https://codereview.chromium.org/14297021/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/sdk.dart (right):

https://codereview.chromium.org/14297021/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/sdk.dart:32: 'the SDK.');
Can you get the automatic detection working? Having to pass this in is a pain.
The shell script still does for historical reasons, but there are other cases
where it isn't provided, I think. (For example, running a non-integration test
suite like version_solver.)

[nweiz, 2013-04-23 19:56:27]

I've updated this to remove the use of "package:" to import pub libraries. This
was incompatible with the original motivation for this CL, which was to allow
pub to import dart2js libraries.

https://codereview.chromium.org/14297021/diff/1/sdk/bin/pub
File sdk/bin/pub (right):

https://codereview.chromium.org/14297021/diff/1/sdk/bin/pub#newcode11
sdk/bin/pub:11: exec "$BIN_DIR"/dart --package-root="$DART_SDK"/packages/ \
On 2013/04/23 19:41:19, Bob Nystrom wrote:
> In a separate patch, can you also move packages under lib/_internal too? I
think
> Dan wanted to see pub's internal package dependencies a little more hidden in
> the SDK.

Do you mean in the SDK, or in the repo as well?

Could you file a bug for this?

https://codereview.chromium.org/14297021/diff/1/sdk/lib/_internal/pub/bin/pub...
File sdk/lib/_internal/pub/bin/pub.dart (right):

https://codereview.chromium.org/14297021/diff/1/sdk/lib/_internal/pub/bin/pub...
sdk/lib/_internal/pub/bin/pub.dart:5: import 'package:pub/src/pub.dart';
On 2013/04/23 19:41:19, Bob Nystrom wrote:
> Does this mean that you have to build the SDK before you can run pub from the
> repo? If I'm hacking pub, is my iteration loop now:
> 
> 1. Change code.
> 2. Build SDK. <-- new step
> 3. Run test.
> 
> ?

I've removed package: pub imports, but no, that's not what this would mean.
Pub's library would also get linked into the symlinky "packages" directory,
which is what this would run against from the repo.

https://codereview.chromium.org/14297021/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/pub.dart (right):

https://codereview.chromium.org/14297021/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/pub.dart:202: abstract class PubCommand {
On 2013/04/23 19:41:19, Bob Nystrom wrote:
> Move this into its own file and then move the rest of this code to
bin/pub.dart?

There's already a TODO for that in bin/pub.dart. I think it's out-of-scope for
this CL.

https://codereview.chromium.org/14297021/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/sdk.dart (right):

https://codereview.chromium.org/14297021/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/sdk.dart:32: 'the SDK.');
On 2013/04/23 19:41:19, Bob Nystrom wrote:
> Can you get the automatic detection working? Having to pass this in is a pain.
> The shell script still does for historical reasons, but there are other cases
> where it isn't provided, I think. (For example, running a non-integration test
> suite like version_solver.)

This code was broken; it would return the repo root, which doesn't contain
anything pub expects from the SDK. I'm pretty sure it was never being run.

I can probably find a way to detect the SDK even when DART_SDK isn't passed, but
I'm reluctant to add dead code.

[Bob Nystrom, 2013-04-23 20:26:14]

LGTM.

https://codereview.chromium.org/14297021/diff/1/sdk/bin/pub
File sdk/bin/pub (right):

https://codereview.chromium.org/14297021/diff/1/sdk/bin/pub#newcode11
sdk/bin/pub:11: exec "$BIN_DIR"/dart --package-root="$DART_SDK"/packages/ \
On 2013/04/23 19:56:27, nweiz wrote:
> On 2013/04/23 19:41:19, Bob Nystrom wrote:
> > In a separate patch, can you also move packages under lib/_internal too? I
> think
> > Dan wanted to see pub's internal package dependencies a little more hidden
in
> > the SDK.
> 
> Do you mean in the SDK, or in the repo as well?

In the SDK.

> 
> Could you file a bug for this?

Sure: https://code.google.com/p/dart/issues/detail?id=10160

https://codereview.chromium.org/14297021/diff/1/sdk/lib/_internal/pub/bin/pub...
File sdk/lib/_internal/pub/bin/pub.dart (right):

https://codereview.chromium.org/14297021/diff/1/sdk/lib/_internal/pub/bin/pub...
sdk/lib/_internal/pub/bin/pub.dart:5: import 'package:pub/src/pub.dart';
On 2013/04/23 19:56:27, nweiz wrote:
> On 2013/04/23 19:41:19, Bob Nystrom wrote:
> > Does this mean that you have to build the SDK before you can run pub from
the
> > repo? If I'm hacking pub, is my iteration loop now:
> > 
> > 1. Change code.
> > 2. Build SDK. <-- new step
> > 3. Run test.
> > 
> > ?
> 
> I've removed package: pub imports, but no, that's not what this would mean.
> Pub's library would also get linked into the symlinky "packages" directory,
> which is what this would run against from the repo.

SGTM. I wasn't sure if it copied or linked, but it looks like it's linking.

https://codereview.chromium.org/14297021/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/sdk.dart (right):

https://codereview.chromium.org/14297021/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/sdk.dart:32: 'the SDK.');
On 2013/04/23 19:56:27, nweiz wrote:
> On 2013/04/23 19:41:19, Bob Nystrom wrote:
> > Can you get the automatic detection working? Having to pass this in is a
pain.
> > The shell script still does for historical reasons, but there are other
cases
> > where it isn't provided, I think. (For example, running a non-integration
test
> > suite like version_solver.)
> 
> This code was broken; it would return the repo root, which doesn't contain
> anything pub expects from the SDK. I'm pretty sure it was never being run.
> 
> I can probably find a way to detect the SDK even when DART_SDK isn't passed,
but
> I'm reluctant to add dead code.

I'm fine with leaving it out for now then.

[nweiz, 2013-04-23 21:46:45]

Committed patchset #2 manually as r21907 (presubmit successful).