sdk/bin/pub - Issue 14297021: Move pub into sdk/lib/_internal.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sdk/bin/pub

Issue 14297021: Move pub into sdk/lib/_internal. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 #!/bin/bash	1 #!/bin/bash

2 # Run pub.dart on the Dart VM. This script assumes the Dart SDK's directory	2 # Run pub.dart on the Dart VM. This script assumes the Dart SDK's directory

3 # structure.	3 # structure.

4	4

5 # Setting BIN_DIR this way is ugly, but is needed to handle the case where	5 # Setting BIN_DIR this way is ugly, but is needed to handle the case where

6 # dart-sdk/bin has been symlinked to. On MacOS, readlink doesn't work	6 # dart-sdk/bin has been symlinked to. On MacOS, readlink doesn't work

7 # with this case.	7 # with this case.

8 BIN_DIR="$(cd "${0%/*}" ; pwd -P)"	8 BIN_DIR="$(cd "${0%/*}" ; pwd -P)"

9 export DART_SDK="$(cd "${BIN_DIR%/*}" ; pwd -P)"	9 export DART_SDK="$(cd "${BIN_DIR%/*}" ; pwd -P)"

10	10

11 # TODO(dgrove): This doesn't work yet. It will once dartbug.com/6619 is	11 exec "$BIN_DIR"/dart --package-root="$DART_SDK"/packages/ \
	Bob Nystrom 2013/04/23 19:41:19 In a separate patch, can you also move packages un In a separate patch, can you also move packages under lib/_internal too? I think Dan wanted to see pub's internal package dependencies a little more hidden in the SDK. nweiz 2013/04/23 19:56:27 Do you mean in the SDK, or in the repo as well? C Show quoted text On 2013/04/23 19:41:19, Bob Nystrom wrote: > In a separate patch, can you also move packages under lib/_internal too? I think > Dan wanted to see pub's internal package dependencies a little more hidden in > the SDK. Do you mean in the SDK, or in the repo as well? Could you file a bug for this? Bob Nystrom 2013/04/23 20:26:14 In the SDK. Show quoted text On 2013/04/23 19:56:27, nweiz wrote: > On 2013/04/23 19:41:19, Bob Nystrom wrote: > > In a separate patch, can you also move packages under lib/_internal too? I > think > > Dan wanted to see pub's internal package dependencies a little more hidden in > > the SDK. > > Do you mean in the SDK, or in the repo as well? In the SDK. Show quoted text > > Could you file a bug for this? Sure: https://code.google.com/p/dart/issues/detail?id=10160
12 # fixed.	12 "$DART_SDK"/lib/_internal/pub/bin/pub.dart $@

13 exec "$BIN_DIR"/dart "$DART_SDK"/lib/_internal/pub/pub.dart $@

OLD	NEW

« no previous file with comments | « no previous file | sdk/bin/pub.bat » ('j') | sdk/lib/_internal/pub/bin/pub.dart » ('J')