Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 14268019: Basic support for LICM of fully invariant loads. (Closed)

Created:
7 years, 7 months ago by Vyacheslav Egorov (Google)
Modified:
7 years, 7 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Basic support for LICM of fully invariant loads. BUG= R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=22665

Patch Set 1 #

Patch Set 2 : review ready #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -13 lines) Patch
M runtime/vm/flow_graph.h View 1 4 chunks +25 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 4 chunks +11 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 5 chunks +73 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vyacheslav Egorov (Google)
FYI. This is not for commit because loads are hoisted above things they depend on: ...
7 years, 7 months ago (2013-04-29 08:27:01 UTC) #1
Vyacheslav Egorov (Google)
This is rebased and now can be reviewed and landed. Now that side-effect tracking has ...
7 years, 7 months ago (2013-05-13 15:20:46 UTC) #2
Florian Schneider
LGTM.
7 years, 7 months ago (2013-05-14 08:47:07 UTC) #3
Vyacheslav Egorov (Google)
7 years, 7 months ago (2013-05-14 10:28:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22665 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698