Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1694)

Unified Diff: runtime/vm/flow_graph.h

Issue 14268019: Basic support for LICM of fully invariant loads. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: review ready Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph.h
diff --git a/runtime/vm/flow_graph.h b/runtime/vm/flow_graph.h
index ec85594358b9856c6e8981a7eaa983280a271d74..597ef7193b7614325790ca9bb03ed0985e2a2334 100644
--- a/runtime/vm/flow_graph.h
+++ b/runtime/vm/flow_graph.h
@@ -128,10 +128,6 @@ class FlowGraph : public ZoneAllocated {
void ComputeSSA(intptr_t next_virtual_register_number,
ZoneGrowableArray<Definition*>* inlining_parameters);
- // Finds natural loops in the flow graph and attaches a list of loop
- // body blocks for each loop header.
- void ComputeLoops(GrowableArray<BlockEntryInstr*>* loop_headers);
-
// TODO(zerny): Once the SSA is feature complete this should be removed.
void Bailout(const char* reason) const;
@@ -167,6 +163,24 @@ class FlowGraph : public ZoneAllocated {
// after this point.
void disallow_licm() { licm_allowed_ = false; }
+ const ZoneGrowableArray<BlockEntryInstr*>& loop_headers() {
+ if (loop_headers_ == NULL) {
+ loop_headers_ = ComputeLoops();
+ }
+ return *loop_headers_;
+ }
+
+ // Per loop header invariant loads sets. Each set contains load id for
+ // those loads that are not affected by anything in the loop and can be
+ // hoisted out. Sets are computed by LoadOptimizer.
+ ZoneGrowableArray<BitVector*>* loop_invariant_loads() const {
+ return loop_invariant_loads_;
+ }
+ void set_loop_invariant_loads(
+ ZoneGrowableArray<BitVector*>* loop_invariant_loads) {
+ loop_invariant_loads_ = loop_invariant_loads;
+ }
+
private:
friend class IfConverter;
friend class BranchSimplifier;
@@ -202,6 +216,10 @@ class FlowGraph : public ZoneAllocated {
void ReplacePredecessor(BlockEntryInstr* old_block,
BlockEntryInstr* new_block);
+ // Finds natural loops in the flow graph and attaches a list of loop
+ // body blocks for each loop header.
+ ZoneGrowableArray<BlockEntryInstr*>* ComputeLoops();
+
// DiscoverBlocks computes parent_ and assigned_vars_ which are then used
// if/when computing SSA.
GrowableArray<intptr_t> parent_;
@@ -223,6 +241,9 @@ class FlowGraph : public ZoneAllocated {
BlockEffects* block_effects_;
bool licm_allowed_;
+
+ ZoneGrowableArray<BlockEntryInstr*>* loop_headers_;
+ ZoneGrowableArray<BitVector*>* loop_invariant_loads_;
};
« no previous file with comments | « no previous file | runtime/vm/flow_graph.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698