Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 14260012: Do not infer types of arguments of closures and methods named "call". (Closed)

Created:
7 years, 7 months ago by ngeoffray
Modified:
7 years, 7 months ago
Reviewers:
ahe, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not infer types of arguments of closures and methods named "call". R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=22109

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 5 chunks +13 lines, -6 lines 2 comments Download
M sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/universe/universe.dart View 1 chunk +5 lines, -3 lines 0 comments Download
A tests/language/call_argument_inference_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ngeoffray
7 years, 7 months ago (2013-04-29 10:03:04 UTC) #1
ahe
I'll try patching it in locally. https://codereview.chromium.org/14260012/diff/2001/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/14260012/diff/2001/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode2174 sdk/lib/_internal/compiler/implementation/resolution/members.dart:2174: if (element != ...
7 years, 7 months ago (2013-04-29 10:07:41 UTC) #2
ngeoffray
https://codereview.chromium.org/14260012/diff/2001/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/14260012/diff/2001/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode2174 sdk/lib/_internal/compiler/implementation/resolution/members.dart:2174: if (element != null && element.isConstructor()) { On 2013/04/29 ...
7 years, 7 months ago (2013-04-29 10:12:09 UTC) #3
ahe
I patched this in, and dart2js now self-hosts and the resulting JavaScript can compile everything ...
7 years, 7 months ago (2013-04-29 10:19:16 UTC) #4
ahe
LGTM
7 years, 7 months ago (2013-04-29 10:25:05 UTC) #5
ngeoffray
7 years, 7 months ago (2013-04-29 10:38:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r22109 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698