sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart - Issue 14260012: Do not infer types of arguments of closures and methods named "call".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart

Issue 14260012: Do not infer types of arguments of closures and methods named "call". (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/resolution/members.dart ('K') | « sdk/lib/_internal/compiler/implementation/resolution/members.dart ('k') | sdk/lib/_internal/compiler/implementation/universe/universe.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (revision 22108)

+++ sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (working copy)

@@ -829,6 +829,11 @@

ArgumentsTypes arguments,

Selector constraint,

bool inLoop) {

+ // Bailout for closure calls. We're not tracking types of

+ // arguments for closures.

+ if (callee.isInstanceMember() && selector.isClosureCall()) {

+ return;

+ }

if (inLoop) {

// For instance methods, we only register a selector called in a

// loop if it is a typed selector, to avoid marking too many