Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 142563006: Make the Dart code generators handle the Image constructor specified in the IDL without crashing or… (Closed)

Created:
6 years, 10 months ago by Jacob
Modified:
6 years, 10 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make the Dart code generators handle the Image constructor specified in the IDL without crashing or generating multiple constructors. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=32621

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -48 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +0 lines, -44 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jacob
Step 1 of fixing JS Image constructors.
6 years, 10 months ago (2014-02-12 20:39:00 UTC) #1
vsm
lgtm
6 years, 10 months ago (2014-02-12 20:41:02 UTC) #2
Jacob
6 years, 10 months ago (2014-02-12 20:47:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32621 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698