Migrate pub away from throwing strings.

Migrate pub away from throwing strings.

This also makes it a little more intelligent about which errors it prints what
information for.

BUG=9921
Committed: https://code.google.com/p/dart/source/detail?r=21698

[Bob Nystrom, 2013-04-18 18:18:31]

https://codereview.chromium.org/14253005/diff/1/utils/pub/entrypoint.dart
File utils/pub/entrypoint.dart (right):

https://codereview.chromium.org/14253005/diff/1/utils/pub/entrypoint.dart#new...
utils/pub/entrypoint.dart:90: throw new UserFacingException('Package ${id.name}
not found in '
That name is a bit strange. How about "PubFailure"?

Also, how do you feel about a helper function that does this, like:

fail(String message) => throw new ...

That might get rid of some of the annoying wrapped strings.

https://codereview.chromium.org/14253005/diff/1/utils/pub/hosted_source.dart
File utils/pub/hosted_source.dart (right):

https://codereview.chromium.org/14253005/diff/1/utils/pub/hosted_source.dart#...
utils/pub/hosted_source.dart:147: '"$package" at $url.\n'
Nit, but I would probably move the whole string to this line and try to get rid
of the line continuation.

https://codereview.chromium.org/14253005/diff/1/utils/pub/pubspec.dart
File utils/pub/pubspec.dart (right):

https://codereview.chromium.org/14253005/diff/1/utils/pub/pubspec.dart#newcode57
utils/pub/pubspec.dart:57: throw new FormatException('Could not parse
$pubspecPath:\n${ex.message}');
This should be a UserFacingException.

https://codereview.chromium.org/14253005/diff/1/utils/tests/pub/command_line_...
File utils/tests/pub/command_line_config.dart (right):

https://codereview.chromium.org/14253005/diff/1/utils/tests/pub/command_line_...
utils/tests/pub/command_line_config.dart:157: throw FormatError("Couldn't parse
stack trace line '$text'.");
FormatException

[nweiz, 2013-04-18 18:37:24]

https://codereview.chromium.org/14253005/diff/1/utils/pub/entrypoint.dart
File utils/pub/entrypoint.dart (right):

https://codereview.chromium.org/14253005/diff/1/utils/pub/entrypoint.dart#new...
utils/pub/entrypoint.dart:90: throw new UserFacingException('Package ${id.name}
not found in '
On 2013/04/18 18:18:31, Bob Nystrom wrote:
> That name is a bit strange. How about "PubFailure"?

"PubFailure" sounds very generic to me. Is an unexpected error not also pub
failing?

> Also, how do you feel about a helper function that does this, like:
> 
> fail(String message) => throw new ...
> 
> That might get rid of some of the annoying wrapped strings.

Done.

https://codereview.chromium.org/14253005/diff/1/utils/pub/hosted_source.dart
File utils/pub/hosted_source.dart (right):

https://codereview.chromium.org/14253005/diff/1/utils/pub/hosted_source.dart#...
utils/pub/hosted_source.dart:147: '"$package" at $url.\n'
On 2013/04/18 18:18:31, Bob Nystrom wrote:
> Nit, but I would probably move the whole string to this line and try to get
rid
> of the line continuation.

This was reformatted anyway due to [fail].

https://codereview.chromium.org/14253005/diff/1/utils/pub/pubspec.dart
File utils/pub/pubspec.dart (right):

https://codereview.chromium.org/14253005/diff/1/utils/pub/pubspec.dart#newcode57
utils/pub/pubspec.dart:57: throw new FormatException('Could not parse
$pubspecPath:\n${ex.message}');
On 2013/04/18 18:18:31, Bob Nystrom wrote:
> This should be a UserFacingException.

Done.

https://codereview.chromium.org/14253005/diff/1/utils/tests/pub/command_line_...
File utils/tests/pub/command_line_config.dart (right):

https://codereview.chromium.org/14253005/diff/1/utils/tests/pub/command_line_...
utils/tests/pub/command_line_config.dart:157: throw FormatError("Couldn't parse
stack trace line '$text'.");
On 2013/04/18 18:18:31, Bob Nystrom wrote:
> FormatException

Done.

[Bob Nystrom, 2013-04-18 20:02:13]

LGTM.

https://codereview.chromium.org/14253005/diff/1/utils/pub/entrypoint.dart
File utils/pub/entrypoint.dart (right):

https://codereview.chromium.org/14253005/diff/1/utils/pub/entrypoint.dart#new...
utils/pub/entrypoint.dart:90: throw new UserFacingException('Package ${id.name}
not found in '
On 2013/04/18 18:37:24, nweiz wrote:
> On 2013/04/18 18:18:31, Bob Nystrom wrote:
> > That name is a bit strange. How about "PubFailure"?
> 
> "PubFailure" sounds very generic to me. Is an unexpected error not also pub
> failing?

I guess so, but I'd consider that more of an underlying failure. Maybe
ApplicationException?

> 
> > Also, how do you feel about a helper function that does this, like:
> > 
> > fail(String message) => throw new ...
> > 
> > That might get rid of some of the annoying wrapped strings.
> 
> Done.

[nweiz, 2013-04-18 20:08:32]

Committed patchset #2 manually as r21698 (presubmit successful).

[nweiz, 2013-04-18 20:12:01]

https://codereview.chromium.org/14253005/diff/1/utils/pub/entrypoint.dart
File utils/pub/entrypoint.dart (right):

https://codereview.chromium.org/14253005/diff/1/utils/pub/entrypoint.dart#new...
utils/pub/entrypoint.dart:90: throw new UserFacingException('Package ${id.name}
not found in '
On 2013/04/18 20:02:13, Bob Nystrom wrote:
> On 2013/04/18 18:37:24, nweiz wrote:
> > On 2013/04/18 18:18:31, Bob Nystrom wrote:
> > > That name is a bit strange. How about "PubFailure"?
> > 
> > "PubFailure" sounds very generic to me. Is an unexpected error not also pub
> > failing?
> 
> I guess so, but I'd consider that more of an underlying failure. Maybe
> ApplicationException?
> 
> > 
> > > Also, how do you feel about a helper function that does this, like:
> > > 
> > > fail(String message) => throw new ...
> > > 
> > > That might get rid of some of the annoying wrapped strings.
> > 
> > Done.
> 

Done.