utils/tests/pub/command_line_config.dart - Issue 14253005: Migrate pub away from throwing strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/tests/pub/command_line_config.dart

Issue 14253005: Migrate pub away from throwing strings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: utils/tests/pub/command_line_config.dart

diff --git a/utils/tests/pub/command_line_config.dart b/utils/tests/pub/command_line_config.dart

index 2fbc3cd4a068c95156ced36be1c80bc4be47a776..9a60951be7c30c88b9e7aeef2a8799c89f8f7d9a 100644

--- a/utils/tests/pub/command_line_config.dart

+++ b/utils/tests/pub/command_line_config.dart

@@ -153,7 +153,9 @@ class _StackFrame {

if (match == null) {

match = coreRegExp.firstMatch(text);

- if (match == null) throw "Couldn't parse stack trace line '$text'.";

+ if (match == null) {

+ throw FormatException("Couldn't parse stack trace line '$text'.");

+ }

isCore = true;

}

« no previous file with comments | « utils/pub/utils.dart ('k') | utils/tests/pub/descriptor/tar.dart » ('j') | no next file with comments »