Lint to prefer x.isNotEmpty vs. !x.isEmpty (#143).

Lint to prefer x.isNotEmpty vs. !x.isEmpty (#143).

R=scheglov@google.com

Committed: https://github.com/dart-lang/linter/commit/154dbfe3653a212626b254e47cec2be06ca64118

[pquitslund, 2015-11-05 04:42:46]

pquitslund@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2015-11-05 04:49:07]

LGTM

https://codereview.chromium.org/1419373009/diff/1/lib/src/rules/prefer_is_not...
File lib/src/rules/prefer_is_not_empty.dart (right):

https://codereview.chromium.org/1419373009/diff/1/lib/src/rules/prefer_is_not...
lib/src/rules/prefer_is_not_empty.dart:31: if (todo.isEmpty) {
Do you mean this line to be?
if (todo.isNotEmpty) {

[pquitslund, 2015-11-05 04:52:41]

Thanks!

https://codereview.chromium.org/1419373009/diff/1/lib/src/rules/prefer_is_not...
File lib/src/rules/prefer_is_not_empty.dart (right):

https://codereview.chromium.org/1419373009/diff/1/lib/src/rules/prefer_is_not...
lib/src/rules/prefer_is_not_empty.dart:31: if (todo.isEmpty) {
On 2015/11/05 04:49:07, scheglov wrote:
> Do you mean this line to be?
> if (todo.isNotEmpty) {

Ha!  Absolutely, yes. :)

[pquitslund, 2015-11-05 16:22:37]

Committed patchset #2 (id:20001) manually as
154dbfe3653a212626b254e47cec2be06ca64118 (presubmit successful).