Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Side by Side Diff: lib/src/rules.dart

Issue 1419373009: Lint to prefer x.isNotEmpty vs. !x.isEmpty (#143). (Closed) Base URL: https://github.com/dart-lang/linter.git@master
Patch Set: doc fix. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/src/linter.dart ('k') | lib/src/rules/prefer_is_not_empty.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library linter.src.rules; 5 library linter.src.rules;
6 6
7 import 'dart:collection'; 7 import 'dart:collection';
8 8
9 import 'package:linter/src/config.dart'; 9 import 'package:linter/src/config.dart';
10 import 'package:linter/src/linter.dart'; 10 import 'package:linter/src/linter.dart';
11 import 'package:linter/src/rules/always_declare_return_types.dart'; 11 import 'package:linter/src/rules/always_declare_return_types.dart';
12 import 'package:linter/src/rules/always_specify_types.dart'; 12 import 'package:linter/src/rules/always_specify_types.dart';
13 import 'package:linter/src/rules/camel_case_types.dart'; 13 import 'package:linter/src/rules/camel_case_types.dart';
14 import 'package:linter/src/rules/constant_identifier_names.dart'; 14 import 'package:linter/src/rules/constant_identifier_names.dart';
15 import 'package:linter/src/rules/empty_constructor_bodies.dart'; 15 import 'package:linter/src/rules/empty_constructor_bodies.dart';
16 import 'package:linter/src/rules/implementation_imports.dart'; 16 import 'package:linter/src/rules/implementation_imports.dart';
17 import 'package:linter/src/rules/library_names.dart'; 17 import 'package:linter/src/rules/library_names.dart';
18 import 'package:linter/src/rules/library_prefixes.dart'; 18 import 'package:linter/src/rules/library_prefixes.dart';
19 import 'package:linter/src/rules/non_constant_identifier_names.dart'; 19 import 'package:linter/src/rules/non_constant_identifier_names.dart';
20 import 'package:linter/src/rules/one_member_abstracts.dart'; 20 import 'package:linter/src/rules/one_member_abstracts.dart';
21 import 'package:linter/src/rules/package_api_docs.dart'; 21 import 'package:linter/src/rules/package_api_docs.dart';
22 import 'package:linter/src/rules/package_prefixed_library_names.dart'; 22 import 'package:linter/src/rules/package_prefixed_library_names.dart';
23 import 'package:linter/src/rules/prefer_is_not_empty.dart';
23 import 'package:linter/src/rules/pub/package_names.dart'; 24 import 'package:linter/src/rules/pub/package_names.dart';
24 import 'package:linter/src/rules/slash_for_doc_comments.dart'; 25 import 'package:linter/src/rules/slash_for_doc_comments.dart';
25 import 'package:linter/src/rules/super_goes_last.dart'; 26 import 'package:linter/src/rules/super_goes_last.dart';
26 import 'package:linter/src/rules/type_init_formals.dart'; 27 import 'package:linter/src/rules/type_init_formals.dart';
27 import 'package:linter/src/rules/unnecessary_brace_in_string_interp.dart'; 28 import 'package:linter/src/rules/unnecessary_brace_in_string_interp.dart';
28 import 'package:linter/src/rules/unnecessary_getters_setters.dart'; 29 import 'package:linter/src/rules/unnecessary_getters_setters.dart';
29 30
30 final Registry ruleRegistry = new Registry() 31 final Registry ruleRegistry = new Registry()
31 ..register(new AlwaysDeclareReturnTypes()) 32 ..register(new AlwaysDeclareReturnTypes())
32 ..register(new AlwaysSpecifyTypes()) 33 ..register(new AlwaysSpecifyTypes())
33 ..register(new CamelCaseTypes()) 34 ..register(new CamelCaseTypes())
34 ..register(new ConstantIdentifierNames()) 35 ..register(new ConstantIdentifierNames())
35 ..register(new EmptyConstructorBodies()) 36 ..register(new EmptyConstructorBodies())
36 ..register(new ImplementationImports()) 37 ..register(new ImplementationImports())
37 ..register(new LibraryNames()) 38 ..register(new LibraryNames())
38 ..register(new LibraryPrefixes()) 39 ..register(new LibraryPrefixes())
39 ..register(new NonConstantIdentifierNames()) 40 ..register(new NonConstantIdentifierNames())
41 ..register(new PreferIsNotEmpty())
40 ..register(new OneMemberAbstracts()) 42 ..register(new OneMemberAbstracts())
41 ..register(new PackageApiDocs()) 43 ..register(new PackageApiDocs())
42 ..register(new PackagePrefixedLibraryNames()) 44 ..register(new PackagePrefixedLibraryNames())
43 ..register(new PubPackageNames()) 45 ..register(new PubPackageNames())
44 ..register(new SlashForDocComments()) 46 ..register(new SlashForDocComments())
45 ..register(new SuperGoesLast()) 47 ..register(new SuperGoesLast())
46 ..register(new TypeInitFormals()) 48 ..register(new TypeInitFormals())
47 ..register(new UnnecessaryBraceInStringInterp()) 49 ..register(new UnnecessaryBraceInStringInterp())
48 // Disabled pending fix: https://github.com/dart-lang/linter/issues/35 50 // Disabled pending fix: https://github.com/dart-lang/linter/issues/35
49 //..register(new UnnecessaryGetters()) 51 //..register(new UnnecessaryGetters())
(...skipping 18 matching lines...) Expand all
68 /// enables `my_rule`. 70 /// enables `my_rule`.
69 /// 71 ///
70 /// Unspecified rules are treated as disabled by default. 72 /// Unspecified rules are treated as disabled by default.
71 Iterable<LintRule> enabled(LintConfig config) => rules 73 Iterable<LintRule> enabled(LintConfig config) => rules
72 .where((rule) => config.ruleConfigs.any((rc) => rc.enables(rule.name))); 74 .where((rule) => config.ruleConfigs.any((rc) => rc.enables(rule.name)));
73 75
74 void register(LintRule rule) { 76 void register(LintRule rule) {
75 _ruleMap[rule.name] = rule; 77 _ruleMap[rule.name] = rule;
76 } 78 }
77 } 79 }
OLDNEW
« no previous file with comments | « lib/src/linter.dart ('k') | lib/src/rules/prefer_is_not_empty.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698