Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 14190014: - Disassociate old page size from new allocatable size. (Closed)

Created:
7 years, 8 months ago by Ivan Posva
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Disassociate old page size from new allocatable size. - Have a different cutoff for large page allocations and default old page size. - Do not align old pages to old page size. - Do not track used space during marking. Committed: https://code.google.com/p/dart/source/detail?r=22064

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -52 lines) Patch
M runtime/vm/gc_marker.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/gc_sweeper.cc View 2 chunks +10 lines, -18 lines 0 comments Download
M runtime/vm/heap.h View 1 3 chunks +7 lines, -1 line 0 comments Download
M runtime/vm/pages.h View 5 chunks +1 line, -16 lines 0 comments Download
M runtime/vm/pages.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ivan Posva
7 years, 8 months ago (2013-04-25 13:19:23 UTC) #1
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/14190014/diff/1/runtime/vm/heap.h File runtime/vm/heap.h (right): https://codereview.chromium.org/14190014/diff/1/runtime/vm/heap.h#newcode195 runtime/vm/heap.h:195: static bool IsNewAllocatableSize(intptr_t size) { the name is ...
7 years, 8 months ago (2013-04-25 22:11:28 UTC) #2
Ivan Posva
https://codereview.chromium.org/14190014/diff/1/runtime/vm/heap.h File runtime/vm/heap.h (right): https://codereview.chromium.org/14190014/diff/1/runtime/vm/heap.h#newcode195 runtime/vm/heap.h:195: static bool IsNewAllocatableSize(intptr_t size) { On 2013/04/25 22:11:28, Vyacheslav ...
7 years, 8 months ago (2013-04-26 06:14:00 UTC) #3
Ivan Posva
7 years, 8 months ago (2013-04-26 06:57:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22064 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698