- Disassociate old page size from new allocatable size.

runtime/vm/heap.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_HEAP_H_
 #define VM_HEAP_H_
 
 #include "platform/assert.h"
 #include "vm/allocation.h"
 #include "vm/flags.h"
@@ skipping 40 matching lines @@
   static const intptr_t kHeapSizeInMB = 512;
   static const intptr_t kCodeHeapSizeInMB = 18;
 
   ~Heap();
 
   uword Allocate(intptr_t size, Space space) {
     ASSERT(!read_only_);
     switch (space) {
       case kNew:
         // Do not attempt to allocate very large objects in new space.
-        if (!PageSpace::IsPageAllocatableSize(size)) {
+        if (!IsNewAllocatableSize(size)) {
           return AllocateOld(size, HeapPage::kData);
         }
         return AllocateNew(size);
       case kOld:
         return AllocateOld(size, HeapPage::kData);
       case kCode:
         return AllocateOld(size, HeapPage::kExecutable);
       default:
         UNREACHABLE();
     }
@@ skipping 113 matching lines @@
     stats_.times_[id] = micros;
   }
 
   void RecordData(int id, intptr_t value) {
     ASSERT((id >= 0) && (id < GCStats::kDataEntries));
     stats_.data_[id] = value;
   }
 
   bool gc_in_progress() const { return gc_in_progress_; }
 
+  static bool IsNewAllocatableSize(intptr_t size) {

[Vyacheslav Egorov (Google), 2013/04/25 22:11:28]

the name is a bit confusing. maybe IsAllocatableInNewSpaceSize()? or something
similar?

[Ivan Posva, 2013/04/26 06:14:00]

I was not happy with the name either. I settled on
IsAllocatableInNewSpace(size).

+    return size <= kNewAllocatableSize;
+  }
+
  private:
   class GCStats : public ValueObject {
    public:
     GCStats() {}
     intptr_t num_;
     Heap::Space space_;
     Heap::GCReason reason_;
 
     class Data : public ValueObject {
     public:
@@ skipping 12 matching lines @@
     };
 
     Data before_;
     Data after_;
     int64_t times_[kDataEntries];
     intptr_t data_[kDataEntries];
 
     DISALLOW_COPY_AND_ASSIGN(GCStats);
   };
 
+  static const intptr_t kNewAllocatableSize = 256 * KB;
+
   Heap();
 
   uword AllocateNew(intptr_t size);
   uword AllocateOld(intptr_t size, HeapPage::PageType type);
 
   // GC stats collection.
   void RecordBeforeGC(Space space, GCReason reason);
   void RecordAfterGC();
   void PrintStats();
 
@@ skipping 38 matching lines @@
   NoHeapGrowthControlScope();
   ~NoHeapGrowthControlScope();
  private:
   bool current_growth_controller_state_;
   DISALLOW_COPY_AND_ASSIGN(NoHeapGrowthControlScope);
 };
 
 }  // namespace dart
 
 #endif  // VM_HEAP_H_