Issue 14178017: Mark list_test as failing on browsers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14178017: Mark list_test as failing on browsers. (Closed)

Created:
7 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 8 months ago

Reviewers:
karlklose, kasperl

CC:
reviews_dartlang.org, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mark list_test as failing on browsers. Seems to be failing in UInt8List.operator[] with invalid argument. BUG=http://dartbug.com/10174 Committed: https://code.google.com/p/dart/source/detail?r=21945

Patch Set 1 #

Patch Set 2 : Moved argument checking checking away from typed arrays for now #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -21 lines)			Patch
	M	tests/corelib/corelib.status	View	1	1 chunk	+2 lines, -0 lines	1 comment	Download
	M	tests/corelib/list_test.dart	View	1	2 chunks	+23 lines, -21 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kasperl

This may be fixed by https://codereview.chromium.org/14052009/ that introduces bounds checks when we're optimizing the access ...

7 years, 8 months ago (2013-04-24 12:54:12 UTC) #2

Lasse Reichstein Nielsen

I'll disable checking of argument checking for typed data for now.

7 years, 8 months ago (2013-04-24 12:57:38 UTC) #3

Lasse Reichstein Nielsen

Committed patchset #2 manually as r21945 (presubmit successful).

7 years, 8 months ago (2013-04-24 12:58:10 UTC) #5

karlklose

7 years, 8 months ago (2013-04-24 14:25:53 UTC) #6

Message was sent while issue was closed.

LGTM.

https://codereview.chromium.org/14178017/diff/4001/tests/corelib/corelib.status
File tests/corelib/corelib.status (right):

https://codereview.chromium.org/14178017/diff/4001/tests/corelib/corelib.stat...
tests/corelib/corelib.status:67: [ $compiler == dart2js && ($runtime == firefox
|| $runtime == safari || $runtime == chrome || $runtime == drt) ]
Please remove this section.

Expand Messages | Collapse Messages