Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 14178010: Change libraries map to use Uri. (Closed)

Created:
7 years, 8 months ago by Johnni Winther
Modified:
7 years, 8 months ago
Reviewers:
regis, ahe, Søren Gjesse
CC:
reviews_dartlang.org, gbracha, Anders Johnsen, regis
Visibility:
Public.

Description

Change libraries map to use Uri. Committed: https://code.google.com/p/dart/source/detail?r=21929

Patch Set 1 #

Patch Set 2 : Fix rebase error + add regression test. #

Patch Set 3 : Rebased #

Patch Set 4 : Test updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -30 lines) Patch
M runtime/lib/mirrors.cc View 1 2 3 chunks +6 lines, -8 lines 0 comments Download
M runtime/lib/mirrors_impl.dart View 1 2 5 chunks +20 lines, -15 lines 0 comments Download
M runtime/tests/vm/dart/isolate_mirror_local_test.dart View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/mirrors/mirrors.dart View 1 2 1 chunk +10 lines, -2 lines 0 comments Download
M tests/lib/mirrors/mirrors_test.dart View 1 2 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Johnni Winther
7 years, 8 months ago (2013-04-17 10:14:39 UTC) #1
ahe
LGTM!
7 years, 8 months ago (2013-04-17 10:53:04 UTC) #2
Johnni Winther
@vm-guys: PTAL
7 years, 8 months ago (2013-04-22 12:01:02 UTC) #3
ahe
7 years, 8 months ago (2013-04-22 13:06:10 UTC) #4
regis
LGTM (but I'm not too familiar with that area of the VM)
7 years, 8 months ago (2013-04-22 15:43:12 UTC) #5
Johnni Winther
7 years, 8 months ago (2013-04-24 08:20:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r21929 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698